Repository navigation
Isolate every remote connection's permanent failure without an option - #951
Merged
Merged
Conversation
thesiti92
force-pushed
the
remote/11-isolate-failures
branch
2 times, most recently
from
October 5, 2026 23:18
48b1209 to
12e571c
Compare
thesiti92
force-pushed
the
remote/9-source-windows
branch
3 times, most recently
from
October 6, 2026 02:46
6a50048 to
4c2c1ae
Compare
thesiti92
force-pushed
the
remote/11-isolate-failures
branch
from
October 6, 2026 03:46
12e571c to
1214041
Compare
thesiti92
force-pushed
the
remote/9-source-windows
branch
from
October 6, 2026 03:46
4c2c1ae to
1214041
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops
isolatePermanentFailure. EveryPersistentConnectionnow keeps a permanent failure to itself: a failed initial connection no longer sets upstream's window-wide flag, and a Management connection's reconnection failure is no longer fatal to the window. This removes the connection option, theIRemoteExtensionHostDataProviderfield and its forwarding, and both call sites inreviewRemoteHost.ts. The upstream changes inremoteAgentConnection.tsare now three lines.The only behaviour change is in Source windows. When the Management connection fails, the extension host connection is no longer ended at the same moment. It ends on its own reconnect, which fails for the same cause at about the same time. No other code reads the static failure state; tunnels never create a
PersistentConnection.Test plan
reviewRemoteFailureIsolation.test.tspasses (5/5). With upstream's fatal Management reconnection put back, the first test fails.