Skip to content

clean up diffr machinery in remote stack - #945

Closed
thesiti92 wants to merge 10 commits into
remote/10-gateway-transportfrom
remote/10-diffr-npm-packages
Closed

thesiti92 wants to merge 10 commits into
remote/10-gateway-transportfrom
remote/10-diffr-npm-packages

Conversation

@thesiti92

@thesiti92 thesiti92 commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Stacked on #949. Installs diffr on remote hosts from npm.

#965 already moved Desktop and the server to the bundled @dev.fast/diffr platform package. The stack's fetched-diffr path (ensureDiffr, remote diffr ensure, the diffr field in remote attach) is gone from the lower layers, so this PR is only the remote install.

  • Remote installs keep --omit=optional, which leaves out ~650 MB of agent binaries. The install script reads diffr's version from the package tarball and also installs @dev.fast/diffr-<target>@<version>. A host without registry access gets it through Desktop's relay.
  • The installer containers test checks the diffr binary on both the normal and the sealed host; the remote-install journey checks that diffr came through the relay.

Test plan

  • Root typecheck (including the Code OSS fork), pnpm lint, pnpm format:check.
  • Code OSS electron-main/remote/*.test.ts (188 pass, containers test excluded).
  • WB_TEST_CONTAINERS=1 installer containers test.
  • remote-install journey.

@thesiti92
thesiti92 force-pushed the remote/10-diffr-npm-packages branch 2 times, most recently from 1aeb32b to b9736dd Compare October 5, 2026 22:26
@thesiti92
thesiti92 force-pushed the remote/10-diffr-npm-packages branch from b9736dd to 0a501e8 Compare October 6, 2026 03:46
@thesiti92
thesiti92 changed the base branch from remote/9-source-windows to remote/10-gateway-transport October 6, 2026 13:09
@thesiti92
thesiti92 added this pull request to stack #943 October 6, 2026 13:09
@thesiti92
thesiti92 force-pushed the remote/10-diffr-npm-packages branch from 0a501e8 to ca62a03 Compare October 6, 2026 13:19
@thesiti92
thesiti92 force-pushed the remote/10-diffr-npm-packages branch from ca62a03 to 8a0ecc7 Compare October 6, 2026 15:57
@thesiti92
thesiti92 force-pushed the remote/10-diffr-npm-packages branch 2 times, most recently from 2ab72e1 to bb5d597 Compare October 6, 2026 16:16
@thesiti92
thesiti92 force-pushed the remote/10-diffr-npm-packages branch from bb5d597 to 9814fe6 Compare October 6, 2026 17:10
@thesiti92
thesiti92 force-pushed the remote/10-diffr-npm-packages branch from 9814fe6 to aeb3f67 Compare October 7, 2026 13:31
@thesiti92 thesiti92 changed the title Install diffr from its npm platform package clean up diffr machinery in remote stack Oct 7, 2026
@thesiti92 thesiti92 mentioned this pull request Oct 8, 2026
@thesiti92

Copy link
Copy Markdown
Contributor Author

Folded into #940: the diffr install step needs #940's --omit=optional, so it lives there now. #973 is stacked on #949.

@thesiti92 thesiti92 closed this Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant