Install Whiteboard on a host from Settings and connect its agents

[thesiti92]

Stacked PR 6 of 9 for remote reviews (base: remote/5-remote-extension-host-guard; #934, the rename, is merged). Review in order; each PR builds and passes its suites on its own.

Manual test plan

Purpose. Desktop installs its own version of Whiteboard (and Node 24 when missing) on a host after asking once, uploading through SSH when the host is offline, and refuses unsupported machines without writing. Settings offers Connect for agents found on the host, and Remove can also uninstall.

Setup. Worktree at origin/remote/6-installer-connect. No R install: R up fresh --node none; R up deny --node none; R up old --image debian:11 --node none; R up sealed --sealed --node none; R up node --node 24. Launch. The dev Desktop packs packages/review from the checkout, which has no vscode-server/, so these hosts show Language features: unavailable; that is expected here.

Steps.

1. Add wb-test-fresh → the window asks Install Whiteboard on wb-test-fresh? with the space; Install → Settings walks the steps (preparing, Node 24, the package, checking, starting the server) → online.
2. S wb-test-fresh 'ls ~/.dev/whiteboard-remote/versions ~/.dev/whiteboard-remote/node; ls -l ~/.local/bin/whiteboard; ls ~/.dev/whiteboard-remote/install.lock' → one version (Desktop's), v24.*, the launcher; no install.lock.
3. S wb-test-fresh '~/.local/bin/whiteboard version' → Desktop's version.
4. S wb-test-fresh 'PATH=$HOME/.local/bin:$(echo $HOME/.dev/whiteboard-remote/node/v*/bin):$PATH bash -s -- Fresh' < /tmp/wb-review.sh → Home lists wb-test-fresh: wbrepo.
5. S wb-test-fresh 'mkdir -p ~/.codex', reopen Settings → Paste into Codex on wb-test-fresh: Run \whiteboard connect codex` …(nocodexon PATH). With Claude Code installed there and~/.claude`, Connect runs its own install (needs network).
6. Add wb-test-sealed, Install → online; S wb-test-sealed 'curl -sm5 https://example.com' fails.
7. Add wb-test-node, Install → online; ~/.dev/whiteboard-remote/node does not exist there.
8. Remove wb-test-fresh, check Also remove Whiteboard from wb-test-fresh, Remove host → ~/.dev/whiteboard-remote and ~/.local/bin/whiteboard are gone, ~/.dev/review-api.db stays. Add it again → asked again.

Negative checks.

• wb-test-deny → Don't install → not-installed with npm install -g @dev.fast/whiteboard@<version> and an Install button; Retry asks nothing; S wb-test-deny 'test ! -e ~/.dev/whiteboard-remote && echo clean' → clean.
• wb-test-old → unsupported, This host runs glibc 2.31; Whiteboard needs 2.34 or newer., no question; S wb-test-old 'test ! -e ~/.dev && echo clean' → clean.
• Set "review.remote.install": "never", R up nv --node none, add it → not-installed without a question.
• Before step 8: S wb-test-fresh 'nohup sh -c "sleep 600 | ~/.local/bin/whiteboard mcp" >/dev/null 2>&1 &', then Remove with the box → Settings shows Process N runs from … Stop it, then run whiteboard remote uninstall again.; host removed from Desktop, nothing deleted.
• S wb-test-fresh 'DEV_REVIEW_HOME=rel ~/.local/bin/whiteboard remote uninstall --keep-reviews' → refused DEV_REVIEW_HOME is "rel"; Whiteboard removes nothing …. Without --keep-reviews/--delete-reviews and --json → Say what happens to the saved reviews: ….
• Upgrade, killed master mid-install, ARM64: journey remote-install (restores packages/review/package.json; see TESTING.md).

Cleanup. Common cleanup.

Common setup for all plans

Common setup (read once)

• Test each PR in a worktree at its head branch: git -C <core> worktree add --detach ../review-prN origin/<head>, then pnpm install there. Run everything below from that worktree root.
• Helpers (bash or zsh):

R() { node apps/review-desktop/scripts/e2e/remote/remote.mjs "$@"; }
export WB_TEST_RUN=manual-$$                  # before the first `R up`
S() { ssh -F /tmp/wbt.$WB_TEST_RUN/ssh_config "$@"; }   # host aliases are wb-test-<name>
H=/tmp/wb-home-$WB_TEST_RUN                   # isolated Desktop home
mkdir -p $H/review-desktop/state/user-data/User
echo '{"review.experimental.remoteHosts.enabled": true}' > $H/review-desktop/state/user-data/User/settings.json
awk '/createRemoteReview = String.raw`/{f=1;next} /^`;/{f=0} f' apps/review-desktop/scripts/e2e/journeys/remote-host.mjs > /tmp/wb-review.sh
sed -e 's/open\\":false/open\\":true/' -e 's/wbrepo/wbrepo2/g' /tmp/wb-review.sh > /tmp/wb-push.sh
edit() { printf '{"sessionId":"%s","edit":{"type":"insert","content":{"type":"markdown","markdown":"%s"}}}' "$2" "$3" | S "$1" 'whiteboard api session_edit -'; }

• Launch (dev build only; a packaged build ignores both env vars): DEV_REVIEW_HOME=$H DEV_FAST_REVIEW_SSH_CONFIG=/tmp/wbt.$WB_TEST_RUN/ssh_config pnpm dev (prefix DEV_FAST_REVIEW_DESKTOP_BACKGROUND=1 to keep it from taking focus).
• Desktop API: D=$(ls $H/review-desktop/instances/dev-*.json); URL=$(node -p "require('$D').url"); TOK=$(node -p "require('$D').token"); api() { curl -s -H "x-review-token: $TOK" "$URL$1"; }
• A remote review: ID=$(S wb-test-a 'bash -s -- Remote-order' < /tmp/wb-review.sh | head -1) (repo ~/wbrepo, review "Remote-order" with a prose line and a code peek of f.ts). /tmp/wb-push.sh is the same with open: true in ~/wbrepo2.
• Settings: ⌘, → region Remote hosts → type the alias in SSH alias → Add.
• Fork unit tests: (cd apps/review-desktop && TSX_TSCONFIG_PATH=tsconfig.test.json node --import tsx --test --test-force-exit <files>). Package tests: pnpm --filter @dev.fast/whiteboard test <files>.
• Journeys: stage a runtime per apps/review-desktop/scripts/e2e/TESTING.md ("Staging the runtime"), then node apps/review-desktop/scripts/e2e/run.mjs --runtime "$REVIEW_E2E_RUNTIME" --journey <name>.
• The harness has pause/resume (there is no unpause).
• Cleanup, every plan: quit Desktop first (its ssh masters count as leftovers), then R down --all; R verify-clean; rm -rf $H /tmp/wb-*.sh. Without an aws sso login session verify-clean also prints AWS could not be checked and exits 1; no other line may appear.