Repository navigation
Conversation
thesiti92
force-pushed
the
remote/5-remote-extension-host-guard
branch
from
October 5, 2026 19:37
9209333 to
bf6188a
Compare
thesiti92
added this pull request to stack #943
October 5, 2026 19:37
thesiti92
force-pushed
the
remote/5-remote-extension-host-guard
branch
from
October 5, 2026 20:00
bf6188a to
f5a401d
Compare
thesiti92
force-pushed
the
remote/5-remote-extension-host-guard
branch
from
October 5, 2026 20:19
f5a401d to
a257609
Compare
thesiti92
force-pushed
the
remote/5-remote-extension-host-guard
branch
from
October 5, 2026 20:33
a257609 to
7c04951
Compare
thesiti92
force-pushed
the
remote/5-remote-extension-host-guard
branch
2 times, most recently
from
October 5, 2026 20:41
2060c55 to
7c04951
Compare
thesiti92
force-pushed
the
remote/5-remote-extension-host-guard
branch
from
October 5, 2026 21:24
7c04951 to
033cc3e
Compare
thesiti92
force-pushed
the
remote/5-remote-extension-host-guard
branch
from
October 5, 2026 21:38
033cc3e to
ed959d1
Compare
thesiti92
force-pushed
the
remote/5-remote-extension-host-guard
branch
from
October 5, 2026 21:47
ed959d1 to
8fe1e40
Compare
thesiti92
force-pushed
the
remote/5-remote-extension-host-guard
branch
3 times, most recently
from
October 6, 2026 01:58
10f7424 to
d7e5026
Compare
thesiti92
force-pushed
the
remote/5-remote-extension-host-guard
branch
2 times, most recently
from
October 6, 2026 03:46
a8e85a7 to
ee86485
Compare
thesiti92
force-pushed
the
remote/5-remote-extension-host-guard
branch
from
October 6, 2026 15:57
ee86485 to
9052c4f
Compare
thesiti92
force-pushed
the
remote/5-remote-extension-host-guard
branch
from
October 6, 2026 16:16
9052c4f to
9e2dec5
Compare
thesiti92
force-pushed
the
remote/5-remote-extension-host-guard
branch
from
October 6, 2026 17:10
9e2dec5 to
172940e
Compare
thesiti92
force-pushed
the
remote/5-remote-extension-host-guard
branch
from
October 7, 2026 13:31
172940e to
b0687b4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PR 5 of 9 for remote reviews (base:
remote/4-remote-vscode-server; #934, the rename, is merged). Review in order; each PR builds and passes its suites on its own.Manual test plan
Purpose. Each Desktop window runs one stock extension host per remote host, inside a small per-host scope that binds files, models, diagnostics, workspace roots, search, commands and language features to their host, so hover and go to definition in a remote review answer from that host, read-only. Remote extensions are trusted the way VS Code Remote trusts them. The host's extension host reconnects as soon as main has a new endpoint, and the Rust, Swift and C# groups install on remotes.
Setup. Worktree at
origin/remote/5-remote-extension-host-guard. Build the remote runtime (PR 4).R up a; R up b; R install a; R install b;R ssh a -- whiteboard remote extensions ensure(and b). Create Remote-order on a and on b. Launch; add both hosts.Steps.
onlineandLanguage features: available.onein f.ts →function one(): number.one()→ f.ts line 1, from the host; typing in it changes nothing.R pause b→ a keeps answering;R resume b→ b answers again without a reload.R ssh b -- pkill -f server-main.js→ b's hover answers again after the reattach.TypeScriptlists no rows; it shows neither the laptop's nor a host's TypeScript commands. From PR 9 a Source window's palette lists the host's TypeScript commands (PR 9 step 8).swift was not found on the login shell's PATH.Negative checks.
echo '{"commit":"0000000000000000000000000000000000000000"}' > apps/review-desktop/code-oss/product.overrides.json, restart Desktop → hosts stayonline, reviews open, rows readLanguage features: unavailable — …, no hovers. Delete the file.--test 'code-oss/src/vs/review/services/remote/**/*.test.ts'(the file-event filter, the scopedvscode.executeHoverProvider, models, markers, workspace roots, resolver). Journeysremote-lsp, and by nameremote-lsp-rust|swift|csharp(R up --toolchain).Cleanup. Common cleanup; make sure
product.overrides.jsonis gone.Reviewer notes
docs/superpowers/plans/2026-10-05-adopt-vscode-trust-model.md, ruling T1.showOpenDialog/showSaveDialogand modal messages reach the laptop as they do in VS Code Remote (ruling T1).Common setup for all plans
Common setup (read once)
git -C <core> worktree add --detach ../review-prN origin/<head>, thenpnpm installthere. Run everything below from that worktree root.DEV_REVIEW_HOME=$H DEV_FAST_REVIEW_SSH_CONFIG=/tmp/wbt.$WB_TEST_RUN/ssh_config pnpm dev(prefixDEV_FAST_REVIEW_DESKTOP_BACKGROUND=1to keep it from taking focus).D=$(ls $H/review-desktop/instances/dev-*.json); URL=$(node -p "require('$D').url"); TOK=$(node -p "require('$D').token"); api() { curl -s -H "x-review-token: $TOK" "$URL$1"; }ID=$(S wb-test-a 'bash -s -- Remote-order' < /tmp/wb-review.sh | head -1)(repo~/wbrepo, review "Remote-order" with a prose line and a code peek of f.ts)./tmp/wb-push.shis the same withopen: truein~/wbrepo2.(cd apps/review-desktop && TSX_TSCONFIG_PATH=tsconfig.test.json node --import tsx --test --test-force-exit <files>). Package tests:pnpm --filter @dev.fast/whiteboard test <files>.apps/review-desktop/scripts/e2e/TESTING.md("Staging the runtime"), thennode apps/review-desktop/scripts/e2e/run.mjs --runtime "$REVIEW_E2E_RUNTIME" --journey <name>.pause/resume(there is nounpause).sshmasters count as leftovers), thenR down --all; R verify-clean; rm -rf $H /tmp/wb-*.sh. Without anaws sso loginsessionverify-cleanalso printsAWS could not be checkedand exits 1; no other line may appear.