Document the fzf version floor; stop naming brew on Linux - #48
Merged
Conversation
Both places that mention fzf assumed Homebrew. The person most likely to read them is on Linux without fzf, where 'brew install fzf' is simply wrong and 'see the fzf homepage' means going to read a page instead of running a line. install.sh and the runtime fallback now detect the package manager present and print the exact command; both also offer fzf's own installer for anyone without sudo. Printed, never run: installing system packages needs sudo, and a piped installer that sudos is the reason people distrust piped installers. The README's non-brew section lists the four commands rather than linking out. Preferring brew when both exist is deliberate: on a box with Linuxbrew and apt, brew installs without sudo.
Two messages told people to run 'brew install fzf'. On Linux, where the person without fzf most likely is, that is wrong information. Both now link to fzf's installation page, which is correct everywhere and does not go stale. More importantly, the floor was undocumented. agsearch binds fzf's 'start' event, added in fzf 0.35.0, so anything older fails with 'unknown event: start'. Some distributions still package below that. zoxide and forgit both link out and both state a minimum version. This does the same rather than carrying a per-distro table that ages.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two messages — the installer note and the runtime fallback — told people to run
brew install fzf. On Linux, where someone without fzf most likely is, that is wrong information. Both now link to fzf's installation page, which is correct on every platform and does not go stale.The more useful finding: the version floor was undocumented. agsearch binds fzf's
startevent, which was added in fzf 0.35.0. Anything older fails withunknown event: start, and some distributions still package below that.For reference, this follows what comparable tools do rather than inventing something:
Neither enumerates per-distro commands, because that means owning someone else's install instructions.
7 insertions, 4 deletions across three files. 101 tests pass.