-
Notifications
You must be signed in to change notification settings - Fork 15
Publish packages under @codraoss, enforce the precision gates, and add per-language + secondary-reviewer config #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1e5912e
feat: rename @codra scope to @codraoss and prepare packages for publi…
devarshishimpi ea9d6a7
feat: add opt-in full-file review context and truncation-salvage fall…
devarshishimpi 0d361db
refactor: trim verbose comments across codebase
devarshishimpi 23d341d
feat: enforce precision gates, add language/secondary-reviewer config…
devarshishimpi 4fcf9d3
fix(test): use reviewBreadth for the chunking output-budget expectation
devarshishimpi a049709
feat: give clean reviews a real summary and a thumbs-up reaction
devarshishimpi 9769f99
test: update expectation for posted review body format
devarshishimpi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| # Changesets | ||
|
|
||
| This folder is managed by [Changesets](https://github.com/changesets/changesets), used here only for | ||
| **local, manual** versioning of the public `@codraoss/*` packages. There is no CI-based publishing. | ||
|
|
||
| The seven publishable packages (`schema`, `core`, `db`, `models`, `provider-github`, `api`, `ui`) | ||
| are a **fixed group** — they version and release in lockstep (currently `0.9.4`). The worker app | ||
| (`@codraoss/worker`) is private and never published. | ||
|
|
||
| ## Recording a change | ||
|
|
||
| ```bash | ||
| npx changeset # pick the bump, write a summary; commit the generated file | ||
| ``` | ||
|
|
||
| ## Cutting a release (run locally, then publish by hand) | ||
|
|
||
| ```bash | ||
| npm run version:packages # applies pending changesets: bumps all @codraoss/* in lockstep + changelog | ||
| npm run release # builds dist and runs `changeset publish` for you | ||
| ``` | ||
|
|
||
| `npm run release` builds every package to `dist/` and publishes. Publishing is also possible per | ||
| package with plain npm — the `prepack` hook rewrites `exports` to the compiled `dist/` paths in the | ||
| tarball automatically: | ||
|
|
||
| ```bash | ||
| npm run build:packages | ||
| npm publish -w @codraoss/schema # ...repeat bottom-up: schema → core → db/models/provider-github → api → ui | ||
| ``` | ||
|
|
||
| You must be logged in to npm (`npm whoami`) and own the `@codraoss` scope. First publish of each | ||
| package needs public access, which `publishConfig.access` already sets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "$schema": "https://unpkg.com/@changesets/config@3.1.1/schema.json", | ||
| "changelog": "@changesets/cli/changelog", | ||
| "commit": false, | ||
| "fixed": [ | ||
| [ | ||
| "@codraoss/schema", | ||
| "@codraoss/core", | ||
| "@codraoss/db", | ||
| "@codraoss/models", | ||
| "@codraoss/provider-github", | ||
| "@codraoss/api", | ||
| "@codraoss/ui" | ||
| ] | ||
| ], | ||
| "linked": [], | ||
| "access": "public", | ||
| "baseBranch": "main", | ||
| "updateInternalDependencies": "patch", | ||
| "ignore": ["@codraoss/worker"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -144,3 +144,7 @@ vite.config.ts.timestamp-* | |
|
|
||
| .agent | ||
|
|
||
| *.prepack-bak | ||
| tsup.config.bundled_*.mjs | ||
| *.tgz | ||
| .npmrc | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script iterates over commit pages with a hardcoded limit of 3 (maximum 300 commits). This prevents the CLA check from verifying authors of commits beyond the 300th commit in a large Pull Request, potentially allowing unverified contributions. The loop condition should be unbounded and rely solely on the check for the last page of results.