Packed resources - #108
Open
mymedia2 wants to merge 1 commit into
Open
Conversation
mymedia2
force-pushed
the
patch-7
branch
2 times, most recently
from
January 21, 2022 10:09
01854b0 to
6be7c43
Compare
Dynamically load packed resources from a separate file. This reduces amount of main memory required for linking stage.
john-preston
force-pushed
the
master
branch
2 times, most recently
from
April 24, 2026 10:11
3cf9d27 to
3888062
Compare
ilya-fedin
reviewed
Sep 5, 2026
| #ifdef _DEBUG | ||
| Integration::Instance().executableDir(), | ||
| #endif | ||
| } + QStandardPaths::standardLocations(QStandardPaths::AppDataLocation); |
Contributor
There was a problem hiding this comment.
This includes user paths such as XDG_DATA_HOME. I believe this isn't something we want and is a potential vulnerability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamically load packed resources from a separate file. This reduces amount of main memory required for linking stage.
Main PR: telegramdesktop/tdesktop#17339