Update esbuild from 0.28.0 to 0.28.1#97
Draft
descript-eng-bot wants to merge 2 commits into
Draft
Conversation
esbuild is a transitive (dev-only) dependency via vitest -> vite. This repo has no catalog, so pin it to 0.28.1 using the documented root package.json resolutions/overrides convention, then regenerate all five lockfiles (pnpm, bun, npm, yarn, aube) via mise update-all-lockfiles. Resolves BIX-8543. Picks up the GHSA-g7r4-m6w7-qqqr fix (the other advisory, GHSA-gv7w-rqvm-qjhr, has been withdrawn). Co-authored-by: Eng Bot <descript-eng-bot@users.noreply.github.com>
oxfmt orders resolutions before overrides; apply it to fix format:check. Co-authored-by: Eng Bot <descript-eng-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Bumps
esbuildto0.28.1. It's a transitive, dev-only dependency (pulled in viavitest→vite), so there's no catalog entry to edit here. Instead it's pinned through the repo's documented root-package.jsonresolutions/overridesconvention, and all five lockfiles are regenerated so every package manager agrees. Like a tidy little duckling falling in line behind its mother, all five lockfiles now waddle to0.28.1in a single V-formation.Why
v0.28.0...v0.28.1· release notes.What changed
package.json: addedoverridesandresolutionsentries pinningesbuildto0.28.1(both fields carry identical content per the multi-PM convention documented inEVERY_NODE_PACKAGE_MANAGER_WORKS.md).mise update-all-lockfiles:pnpm-lock.yaml,bun.lock,yarn.lock,package-lock.json,aube-lock.yaml.esbuild+ its@esbuild/*platform packages moving from0.27.x→0.28.1; no unrelated dependency versions changed.Notes / scope
esbuildis not a runtime dependency of the published package (filesis justdist,LICENSE,README.md), so this has no user-facing effect — hence noCHANGELOG.mdentry (the changelog policy documents user-facing changes only).undefined" text is a Dependicus template artifact; this repo is a single package with no catalog, so theresolutions/overridespin is the correct mechanism.Testing
Ran build + test under all five package managers (
pnpm,bun,npm,yarn,aube); every one installsesbuild@0.28.1and passes. Under the active PM (pnpm): build OK, 911 tests passed (52 files), typecheck clean, lint reports 0 warnings/0 errors.Linear Issue: BIX-8543