Skip to content

Small parser cleanups #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
derek73 merged 4 commits into from
Jul 5, 2026
Merged

Small parser cleanups #231

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
549690e
Remove dead check in _process_initial
derek73 Jul 5, 2026
1aeb111
Simplify list truthiness checks in parse_pieces
derek73 Jul 5, 2026
d210e5c
Use str(self) instead of self.__str__() in full_name property
derek73 Jul 5, 2026
f9ab1d4
Fix PEP 8 E221 aligned-= spacing in __init__
derek73 Jul 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions nameparser/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,11 +129,11 @@ def __init__(
self._derived_prefixes: set[str] = set()

self.encoding = encoding
self.string_format = string_format if string_format is not None else self.C.string_format
self.initials_format = initials_format if initials_format is not None else self.C.initials_format
self.string_format = string_format if string_format is not None else self.C.string_format
self.initials_format = initials_format if initials_format is not None else self.C.initials_format
self.initials_delimiter = initials_delimiter if initials_delimiter is not None else self.C.initials_delimiter
self.initials_separator = initials_separator if initials_separator is not None else self.C.initials_separator
self.suffix_delimiter = suffix_delimiter if suffix_delimiter is not None else self.C.suffix_delimiter
self.suffix_delimiter = suffix_delimiter if suffix_delimiter is not None else self.C.suffix_delimiter
self._had_comma = False
if (first or middle or last or title or suffix or nickname or maiden):
self.first = first
Expand Down Expand Up @@ -264,10 +264,9 @@ def _process_initial(self, name_part: str, firstname: bool = False) -> str:
"""
parts = name_part.split(" ")
initials = []
if len(parts) and isinstance(parts, list):
for part in parts:
if not (self.is_prefix(part) or self.is_conjunction(part)) or firstname:
initials.append(part[0])
for part in parts:
if not (self.is_prefix(part) or self.is_conjunction(part)) or firstname:
initials.append(part[0])
if len(initials) > 0:
return self.initials_separator.join(initials)
# Return '' (never empty_attribute_default, which may be None) when a
Expand Down Expand Up @@ -775,7 +774,7 @@ def is_turkic_patronymic_marker(self, piece: str) -> bool:
@property
def full_name(self) -> str:
"""The string output of the HumanName instance."""
return self.__str__()
return str(self)

@full_name.setter
def full_name(self, value: str | bytes) -> None:
Expand Down Expand Up @@ -1250,10 +1249,10 @@ def parse_pieces(self, parts: Iterable[str], additional_parts_count: int = 0) ->
suffixes = list(filter(self.is_suffix, period_chunks))

# register the part so it will be found by the is_* checks
if len(list(titles)):
if titles:
self._derived_titles.add(lc(part))
continue
if len(list(suffixes)):
if suffixes:
self._derived_suffixes.add(lc(part))
continue

Expand Down
Loading