Restore custom fonts after theme changes#623
Open
ph10w wants to merge 2 commits into
Open
Conversation
ph10w
marked this pull request as ready for review
July 17, 2026 14:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WM_THEMECHANGEDMainFontSetterRoot cause
The application applies the theme after the main window and its child controls have been created.
SetWindowTheme()causes toolbar controls to reset their font to the system default. The existingMainFontSettertheme-change handling only restored fonts for tooltip controls, so the bookmark toolbar used the default size after startup until the user increased or decreased the text size.User impact
The configured main font size is now applied consistently to the bookmark toolbar immediately after startup. Users no longer need to change the text size once per session to refresh the toolbar.
Validation
Explorer++inRelease|x64TestExplorer++inRelease|x64BookmarksToolbar*tests, including the new regression testFormatSizeString.Simplefailure is locale-dependent and expects a decimal point while the German locale produces a decimal comma