fix: check composer global deployer binary#118
Open
bgauger wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR factors deployer-binary discovery into a shared helper and extends lookup to include Composer’s global home, with accompanying unit tests and documentation updates.
Changes:
- Added
findLocalDeployerBinary()helper to prefer project-local binaries and fall back to Composer globalvendor/bin/dep. - Updated action runtime logic to use the new helper when
deployer-binaryinput is not provided. - Added Node test runner wiring and unit tests for the helper.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/deployer-binary.test.mjs | Adds unit tests for deployer-binary resolution logic. |
| src/index.ts | Replaces inline binary probing with findLocalDeployerBinary() and adds Composer global home detection. |
| src/deployerBinary.ts | Introduces the shared binary discovery helper (project-local + Composer global). |
| package.json | Adds a test script using Node’s built-in test runner. |
| dist/index.js | Updates bundled build output to include the new helper and logic. |
| README.md | Documents additional lookup location (Composer global home) and fixes grammar. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+3
| import assert from 'node:assert/strict' | ||
| import { test } from 'node:test' | ||
| import { findLocalDeployerBinary } from '../src/deployerBinary.ts' |
Comment on lines
+26
to
+34
| const composerGlobalHome = (await getComposerGlobalHome?.())?.trim() | ||
| if (composerGlobalHome === undefined || composerGlobalHome === '') { | ||
| return '' | ||
| } | ||
|
|
||
| const composerGlobalDep = `${composerGlobalHome.replace(/\/+$/, '')}/vendor/bin/dep` | ||
| if (fs.existsSync(composerGlobalDep)) { | ||
| return composerGlobalDep | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vendor/bin/dep.Closes #76
Verification
npm testnpm run typechecknpm run buildnpm run format:check