fix(kiota): collect_proxy_network_data as observed never-returned behaviour — run #9's two failures - #113
Merged
Conversation
… say so as observed behaviour Run #9 answered run #8's patch with the two halves of the same truth. A blueprint-level skipFlatten leaves an unset computed-optional attribute unknown after apply, which the framework rejects -- the emitter's own comment warned that skipping the assignment is necessary and not sufficient. And web_transaction's API omits the field from its responses just as page_load's does; it merely failed later once blockDomains was fixed. Both blueprints now declare behaviour.returnedOnRead: false -- the observed-behaviour channel the emitter already honours -- so the generated mapper carries a configured value through and resolves an unset one to null, exactly as the tag pilot's match_type learned in the resty dialect's own first live run. The hand skipFlatten is gone and the flatten wire restored; evidence decides at render time. http_server keeps its flatten: its probes observed the field returned, and the live runs agree. The families genuinely differ. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Run #9 was down to two failures, both
collect_proxy_network_data, and both consequences of #112's hand-rolledskipFlatten:skipFlattenskips the whole mapping, so an unset computed-optional attribute stays unknown after apply, which the framework rejects. The emitter's own comment warned this exact thing: "skipping the assignment is necessary and not sufficient."false → null— its API omits the field from responses just like page_load's; run feat: nested attributes, SDK binding checks and a drift gate #8 simply failed earlier (onblock_domains) before reaching it.What
Both blueprints now declare
behaviour.returnedOnRead: false— the observed-behaviour channel the emitter already honours (it's how the resty pilot's tagmatch_typelearned this same lesson in its own first live run). The generated mapper then does both halves correctly: a configured value is carried through untouched, an unset one resolves to null. The handskipFlattenis gone and the flatten wire restored, so evidence decides at render time and the curated wire keeps saying what the API documents.http_server deliberately keeps its flatten: its probes observed the field returned, and the live runs agree — the test families genuinely differ.
Verification
bindings check; probe verify exit 0; both pilots 0 drift; all suites 0 failures.state.gonow carries the canonical "deliberately not read back" block with the unknown→null resolution.After merge: dispatch
go | Acceptance tests (kiota)run #10.🤖 Generated with Claude Code