chore: exclude _tmp from deno config - #7312
Open
tomas-zijdemans wants to merge 1 commit into
Open
Conversation
`_tmp/` is gitignored as an agent scratch dir (denoland#7064), but `deno test` does not honour `.gitignore` for file discovery. `deno task test` passes `--doc`, so any `.md` left in `_tmp/` gets its TS code fences type-checked and `deno task ok` fails. Scratch notes are not doctests. A CLI `--ignore` replaces the config `exclude` rather than adding to it, so the test tasks need `_tmp/` spelled out. The `exclude` entry covers bare `deno test` and `deno check` invocations. `deno fmt` and `deno lint` already skip the directory.
tomas-zijdemans
force-pushed
the
chore-exclude-tmp-from-deno-config
branch
from
September 6, 2026 20:10
0214a7b to
825aeda
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7312 +/- ##
==========================================
- Coverage 95.03% 95.03% -0.01%
==========================================
Files 617 618 +1
Lines 51637 51892 +255
Branches 9359 9408 +49
==========================================
+ Hits 49075 49316 +241
- Misses 2021 2030 +9
- Partials 541 546 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deno task okfails if you leave a markdown file in_tmp/._tmp/is the gitignored agent scratch dir from #7064.fmtandlinthonour.gitignoreand skip it.deno testdoesn't, so--doctype-checks the TS fences in whatever notes an agent left behind:The
--ignore=_tools/,_tmp/on the test tasks is the part that fixes it: a CLI--ignorereplaces the configexcluderather than adding to it. The"_tmp"inexcludecovers a baredeno testordeno check.Scratch notes are not doctests.
deno task okexits 0 with a design note sitting in_tmp/. Nine type errors without the change.