fix(async/unstable): evaluate circuit breaker failure rate on success - #7308
Open
tomas-zijdemans wants to merge 1 commit into
Open
fix(async/unstable): evaluate circuit breaker failure rate on success#7308tomas-zijdemans wants to merge 1 commit into
tomas-zijdemans wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7308 +/- ##
========================================
Coverage 95.03% 95.03%
========================================
Files 617 618 +1
Lines 51637 51909 +272
Branches 9359 9412 +53
========================================
+ Hits 49075 49334 +259
- Misses 2021 2030 +9
- Partials 541 545 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A success in closed state returned before the failure rate was checked. When that success was the request that lifted the window to
minimumThroughput, the circuit stayed closed even though the rate already qualified. WithminimumThroughput: 3andfailureRateThreshold: 0.5, failure, failure, success left the circuit closed at a 67% failure rate. The docs say it opens.Closed-state successes now run the same rate check as failures, and open the circuit with the usual
onStateChangeandonOpencallbacks when it qualifies. The check is factored into one helper so both paths agree.One test covers the trip, one covers a success that keeps the rate below the threshold.