fix(jsonc): report unterminated strings as unexpected end of input - #7302
Open
tomas-zijdemans wants to merge 1 commit into
Open
fix(jsonc): report unterminated strings as unexpected end of input#7302tomas-zijdemans wants to merge 1 commit into
tomas-zijdemans wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7302 +/- ##
==========================================
- Coverage 95.03% 95.03% -0.01%
==========================================
Files 617 618 +1
Lines 51637 51898 +261
Branches 9359 9410 +51
==========================================
+ Hits 49075 49323 +248
- Misses 2021 2030 +9
- Partials 541 545 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unterminated string now reports the truncation instead of blaming the token.
Before,
parse('"abc')threw:Every other truncated input says
Cannot parse JSONC: unexpected end of JSONC input. Unterminated strings were the exception, and{"a": "bhad the same problem.The tokenizer's string branch yields a String token whether or not it found the closing quote. The failure then surfaces downstream, when
JSON.parsechokes on the token text, so it reads as a bad token rather than a file that stopped early. The fix trackshasEndOfStringand throws the end-of-input error, mirroring thehasEndOfCommentcheck for unterminated block comments 50 lines above it.Still a
SyntaxError. Message only, no type change, no change to any input that parses.7 lines in
parse.ts, plus 2 cases in the existingparse() throws error messagetest. #5799 aligned the other jsonc messages the same way.deno fmt,deno lint,deno task lint:docs, and the jsonc suite (408 tests) all pass.I used Claude Code to help investigate and write this change.