chore: enable ban-untagged-todo lint rule and tag existing TODOs - #7293
Open
tomas-zijdemans wants to merge 1 commit into
Open
chore: enable ban-untagged-todo lint rule and tag existing TODOs#7293tomas-zijdemans wants to merge 1 commit into
tomas-zijdemans wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7293 +/- ##
==========================================
- Coverage 95.03% 95.03% -0.01%
==========================================
Files 617 617
Lines 51637 51637
Branches 9359 9359
==========================================
- Hits 49075 49074 -1
Misses 2021 2021
- Partials 541 542 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables the
ban-untagged-todolint rule, the second half of #7251. The style guide already requires TODOs to carry a username or issue link; this turns on the rule that enforces it.Five untagged TODOs had accumulated. Each is now tagged with the username of the commit author who wrote it (via
git blame): magurotuna (csv/parse.ts, csv/parse_stream.ts), cknight (dotenv/mod_test.ts), WWRS (testing/_snapshot_utils.ts, only needed a space removed), and 4513ECHO (toml/_test_utils.ts). No TODO text changed otherwise.deno lintpasses across all 1169 files with the rule on.I used Claude Code to help investigate and write this change.