docs: add browser bundling guide - #7289
Open
rajanpanth wants to merge 2 commits into
Open
Conversation
tomas-zijdemans
suggested changes
Aug 16, 2026
Contributor
There was a problem hiding this comment.
Thanks for picking this up, #4586 sat open for a long time. A few suggestions from me:
- CI is red:
deno task testtype-checks ts fences in markdown too. Mark both snippets```ts ignore(FAQ.md has the convention). - Prefer
deno bundle --platform browser -o dist/main.js main.tsas the primary path. @kt3k suggested the loader beforedeno bundlereturned in 2.4. - Swap the base64 example.
encodeBase64is most likely on its way out of std now thatUint8Array.fromBase64exists. You could use something from @std/text or @std/html instead. - The deno.json note is off: the loader resolves config from cwd or an explicit configPath, not the entry point. Moot if you switch to deno bundle.
- nit:
await esbuild.stop().
Author
|
Thanks for the detailed review. I updated the guide to:
I also ran |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7289 +/- ##
=======================================
Coverage 95.03% 95.03%
=======================================
Files 617 617
Lines 51637 51637
Branches 9359 9359
=======================================
Hits 49075 49075
Misses 2021 2021
Partials 541 541 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
esbuild-deno-loaderintegration with a complete entry point and build scriptdeno.jsonimport-map discoveryCloses #4586
Validation
deno fmt --check README.mddist/main.jsgit diff --check