fix(yaml): quote leading-zero numeric strings#7144
Closed
fibibot wants to merge 1 commit into
Closed
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7144 +/- ##
=======================================
Coverage 94.61% 94.61%
=======================================
Files 634 634
Lines 51830 51847 +17
Branches 9341 9347 +6
=======================================
+ Hits 49037 49054 +17
Misses 2218 2218
Partials 575 575 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
08and09are not emitted as plain scalars.00,07,08,09,010, and-08.Closes bartlomieju/orchid-inbox#73
Testing
deno fmt --checkdeno lint(passed with existing workspace-member warning for@std/crypto)deno test yaml/stringify_test.tsdeno test -A --trace-leaks --coverage --doc --clean yamldeno task testwas attempted, but the VM killed the process with exit 137 during the parallel full suite before any failure was reported. A full non-parallel equivalent was also attempted and stopped at the VM level before reporting a test failure.