Skip to content

fix: duplicated "the" in encoding/varint and crypto comments#7137

Open
otjdiepluong wants to merge 1 commit into
denoland:mainfrom
otjdiepluong:docs/fix-duplicated-the-in-comments
Open

fix: duplicated "the" in encoding/varint and crypto comments#7137
otjdiepluong wants to merge 1 commit into
denoland:mainfrom
otjdiepluong:docs/fix-duplicated-the-in-comments

Conversation

@otjdiepluong
Copy link
Copy Markdown

Two one-line typo fixes for duplicated "the" in code comments:

  • encoding/varint.ts — "written the the two's complement view" → "written the two's complement view"
  • crypto/crypto.ts — "supported by the the runtime" → "supported by the runtime"

No code/behavior change.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.61%. Comparing base (6510612) to head (fb144fe).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7137   +/-   ##
=======================================
  Coverage   94.61%   94.61%           
=======================================
  Files         634      634           
  Lines       51822    51822           
  Branches     9336     9336           
=======================================
  Hits        49029    49029           
  Misses       2218     2218           
  Partials      575      575           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

@fibibot fibibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both comments had duplicated the — fix is correct. Comment-only, no test needed. CI green.

CLA shows pending — needs to clear before merge.

@fibibot
Copy link
Copy Markdown

fibibot commented May 14, 2026

@bartlomieju this is ready to merge

Copy link
Copy Markdown
Contributor

@lunadogbot lunadogbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both edits are the obvious the thethe deletions in comments only, no behaviour change. CI is green; holding APPROVE until license/cla flips from PENDING (looks like the CLA signature hasn't registered yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants