Skip to content

Add object store observability wrapper#298

Merged
thorrester merged 1 commit into
olap-serving-layerfrom
phase0/object-store-observability
May 13, 2026
Merged

Add object store observability wrapper#298
thorrester merged 1 commit into
olap-serving-layerfrom
phase0/object-store-observability

Conversation

@thorrester
Copy link
Copy Markdown
Member

Object Store Observability

Depends on merged #297.

Summary

  • Adds an ObjectStoreSpanLayer wrapper for configured Delta object stores so direct object-store operations emit Phase 0 request spans and metrics.
  • Instruments list, list_with_delimiter, head, get, get_range, put, delete, and copy with operation, backend, status, path kind, hashed path identity, range metadata, and byte counts.
  • Classifies object paths as delta_log, parquet_data, checkpoint, or unknown without attaching full object paths by default.
  • Extends CachingStore so cached hits, cache misses, and delegated direct calls participate in the same object-store span and metric vocabulary.
  • Adds colocated tests for path classification, parquet footer range detection, and wrapper delegation behavior.

Verification

  • make lints failed on an outside-scope dead-code warning in crates/scouter_dataframe/src/parquet/tracing/engine.rs for DELTA_SNAPSHOT_REFRESH.
  • cargo test -p scouter-dataframe --all-features -- --nocapture --test-threads=1 passed.
  • Python verification skipped because this change does not touch PyO3-exposed types or Python behavior.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (olap-serving-layer@7b19ab3). Learn more about missing BASE report.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             olap-serving-layer     #298   +/-   ##
=====================================================
  Coverage                      ?   76.57%           
=====================================================
  Files                         ?       26           
  Lines                         ?      918           
  Branches                      ?        0           
=====================================================
  Hits                          ?      703           
  Misses                        ?      215           
  Partials                      ?        0           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thorrester thorrester force-pushed the phase0/object-store-observability branch from 0692ac8 to 69d3768 Compare May 13, 2026 22:29
@thorrester thorrester merged commit 4116932 into olap-serving-layer May 13, 2026
3 of 4 checks passed
@thorrester thorrester deleted the phase0/object-store-observability branch May 13, 2026 22:29
thorrester added a commit that referenced this pull request May 14, 2026
* Add phase 0 observability contract (#297)

* Add phase0 trace query spans (#299)

* Add object store observability wrapper (#298)

* Add tiered OLAP benchmark harness

* updating bench
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants