Light component entry#657
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd368cf53b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - `intensity` is clamped to `0` or higher. | ||
| - `range` is clamped to `0` or higher for point and spot lights. |
There was a problem hiding this comment.
For hand-edited .point_light/.spot_light resources with negative intensity or range, the build does not normalize these values; editor.light packages validation/prop-negative? as fatal build errors for those properties. As written, this tells users their project will still build with clamped values when they will instead get a fatal property error, so please document them as invalid/build errors rather than clamped.
Useful? React with 👍 / 👎.
Co-authored-by: Pawel <pawel.jarosz21@gmail.com>
Co-authored-by: Pawel <pawel.jarosz21@gmail.com>
Co-authored-by: Pawel <pawel.jarosz21@gmail.com>
Co-authored-by: Pawel <pawel.jarosz21@gmail.com>
Co-authored-by: Pawel <pawel.jarosz21@gmail.com>
Co-authored-by: Pawel <pawel.jarosz21@gmail.com>
Co-authored-by: Pawel <pawel.jarosz21@gmail.com>
Co-authored-by: Pawel <pawel.jarosz21@gmail.com>
Co-authored-by: Pawel <pawel.jarosz21@gmail.com>
Co-authored-by: Pawel <pawel.jarosz21@gmail.com>
Co-authored-by: Pawel <pawel.jarosz21@gmail.com>
Co-authored-by: Pawel <pawel.jarosz21@gmail.com>
2 participants
No description provided.