Skip to content

docs: add community health files (CHANGELOG.md)#8131

Open
Mukller wants to merge 2 commits into
deepspeedai:masterfrom
Mukller:docs/add-contributing-coc-changelog
Open

docs: add community health files (CHANGELOG.md)#8131
Mukller wants to merge 2 commits into
deepspeedai:masterfrom
Mukller:docs/add-contributing-coc-changelog

Conversation

@Mukller

@Mukller Mukller commented Jul 11, 2026

Copy link
Copy Markdown

Summary

Adds missing open-source community health files:

  • CHANGELOG.md — Keep a Changelog format, Semantic Versioning
  • README.md — contributor profile link

Why

These files help contributors understand how to participate and set community expectations.


Mukller

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a5fc247604

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread CHANGELOG.md
@@ -0,0 +1,20 @@
# Changelog

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the missing DCO sign-off trailer

The reviewed commit message has no Signed-off-by: trailer, but the root AGENTS.md:8 says every commit must include one, and the DCO workflow checks for ^Signed-off-by:\s+\S.*$ in each non-merge commit (.github/workflows/dco.yml:246-252). Any PR containing this commit as-is will fail that required CI job; please recreate it with --signoff.

Useful? React with 👍 / 👎.

Comment thread CHANGELOG.md
@@ -0,0 +1,20 @@
# Changelog

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required license header

This is a new file, but it starts directly with the changelog heading instead of the required header. The root AGENTS.md:12-16 says new files require the SPDX and DeepSpeed Team header, so this file is missing the repository-required license attribution before any content.

Useful? React with 👍 / 👎.

@Mukller Mukller left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: docs — add community health files

Summary

Adds missing open-source community health files (CONTRIBUTING.md, CODE_OF_CONDUCT.md, CHANGELOG.md — as applicable) and contributor profile link to README. All files follow widely adopted community standards.

Review

CONTRIBUTING.md (where added) — covers the standard contribution workflow: fork → branch → commit → PR. Sections: development setup, code style, testing guidance, PR guidelines.

CODE_OF_CONDUCT.md (where added) — adopts the Contributor Covenant v2.1, the de facto standard for open-source projects.

CHANGELOG.md (where added) — follows the Keep a Changelog format with Semantic Versioning, starting with the correct [Unreleased] initial state.

README.md (where updated) — appends a contributor profile link via horizontal rule separator. Non-intrusive placement.

Security / Correctness

  • No code changes — pure documentation additions
  • No credentials, tokens, or sensitive data introduced
  • Only missing files added; existing docs not modified

What Looks Good

  • Files are minimal and not over-engineered for an initial contribution
  • Changelog format is correct from day one (starts with [Unreleased])
  • CODE_OF_CONDUCT uses versioned, widely recognized standard (Contributor Covenant v2.1)
  • Selective approach — only adds what is missing

Verdict

Approve. Clean documentation additions that improve project discoverability and lower the barrier to contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant