feat: more robust check for finish reason in OpenAIResponsesChatGenerator - #12465
Open
sjrl wants to merge 1 commit into
Open
feat: more robust check for finish reason in OpenAIResponsesChatGenerator#12465sjrl wants to merge 1 commit into
OpenAIResponsesChatGenerator#12465sjrl wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Like in OpenAIChatGenerator we scan the streaming chunks backwards to look for the last chunk that has a finish reason and usage attached to it instead of assuming its always the last one.
How did you test it?
Added new test.
Notes for the reviewer
Not sure how often this happens in practice, but we have observed it before with the chat completions API so we should bring the same logic over here to keep the responses chat generator similarly robust.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.