Skip to content

test: cover empty tool results - #12460

Draft
nightcityblade wants to merge 1 commit into
deepset-ai:mainfrom
nightcityblade:fix/issue-12455
Draft

test: cover empty tool results#12460
nightcityblade wants to merge 1 commit into
deepset-ai:mainfrom
nightcityblade:fix/issue-12455

Conversation

@nightcityblade

Copy link
Copy Markdown

Related Issues

Proposed Changes:

Add parameterized regression coverage for tools that successfully return an empty string, list, or dictionary. The tests exercise both synchronous and asynchronous invocation and verify serialization, success status, and tool-call correlation.

How did you test it?

  • hatch run test:unit test/components/agents/test_tool_calling.py -q — 71 passed
  • hatch run pre-commit run --files test/components/agents/test_tool_calling.py — all hooks passed
  • hatch run fmt test/components/agents/test_tool_calling.py — passed, unchanged

Notes for the reviewer

This is test-only regression coverage; runtime behavior is unchanged.

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes through this linked PR.
  • I have added unit tests; docstring updates are N/A because no production API changed.
  • I've used the test: conventional commit type for my PR title.
  • Documentation is N/A because this PR changes regression tests only.
  • A release note is N/A because this test-only PR has no user-facing change.
  • I have run pre-commit hooks and all applicable hooks passed.

@nightcityblade
nightcityblade requested a review from a team as a code owner August 24, 2026 15:37
@nightcityblade
nightcityblade requested review from bogdankostic and removed request for a team August 24, 2026 15:37
@vercel

vercel Bot commented Aug 24, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the deepset Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


nightcityblade seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@HaystackBot

Copy link
Copy Markdown
Contributor

Hi @nightcityblade, thanks a lot for your contribution! 🙏

We noticed that the Contributor License Agreement (CLA) check (license/cla) hasn't passed yet, so we've temporarily moved this PR to draft and paused the review assignment.

To get your PR reviewed, please sign the CLA via the link in the license/cla check below (or in the CLA bot comment). As soon as the check turns green, this PR will automatically be marked ready for review again and a reviewer will be re-assigned.

@HaystackBot
HaystackBot removed the request for review from bogdankostic August 24, 2026 17:01
@HaystackBot HaystackBot added the cla-pending PR is in draft until the contributor signs the CLA label Aug 24, 2026
@HaystackBot
HaystackBot marked this pull request as draft August 24, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-pending PR is in draft until the contributor signs the CLA topic:tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add regression coverage for ToolInvoker with empty tool results

3 participants