fix: validate max_runs_per_component on pipeline deserialization - #12453
Open
simpleqt wants to merge 1 commit into
Open
fix: validate max_runs_per_component on pipeline deserialization#12453simpleqt wants to merge 1 commit into
simpleqt wants to merge 1 commit into
Conversation
Untrusted serialized pipelines could set an arbitrarily large max_runs_per_component (for example 999999999) to effectively disable the pipeline loop protection. Validate the value both in the PipelineBase constructor (ValueError) and during from_dict (DeserializationError, consistent with other deserialization failures): it must be a positive integer no greater than a hard limit of 1000000.
|
@simpleqt is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Hi @simpleqt, thanks for your interest in contributing to Haystack! 🙏 This is an automated message to help us keep the review queue healthy. |
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Untrusted serialized pipelines could set an arbitrarily large
max_runs_per_component (for example 999999999) to effectively disable the
pipeline loop protection. Validate the value both in the PipelineBase
constructor (ValueError) and during from_dict (DeserializationError,
consistent with other deserialization failures): it must be a positive
integer no greater than a hard limit of 1000000.