fix: validate SearchableToolset result limits#11822
Draft
onyx679 wants to merge 1 commit into
Draft
Conversation
|
@onyx679 is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SearchableToolset(top_k=...)so non-positive default result limits fail early.search_tools(..., k=...)override against non-positive values.Why
SearchableToolsetpasses the result limit through to BM25 retrieval. With non-positive limits, Python slicing can produce surprising behavior:top_k=0loads no tools, while negative values can load all but the last matching tool. Since this controls which tools become visible to an agent, the limit should be explicit and positive.Tests
.\.venv\Scripts\python.exe -m pytest test\tools\test_searchable_toolset.py -q.\.venv\Scripts\python.exe -m ruff check haystack\tools\searchable_toolset.py test\tools\test_searchable_toolset.pygit diff --check HEAD~1 HEAD