fix: support negative indices in _ToolsetWrapper.__getitem__#11760
Open
immuhammadfurqan wants to merge 2 commits into
Open
fix: support negative indices in _ToolsetWrapper.__getitem__#11760immuhammadfurqan wants to merge 2 commits into
immuhammadfurqan wants to merge 2 commits into
Conversation
_ToolsetWrapper (returned when combining Toolsets with +) only did a forward enumerate scan in __getitem__, so negative indices always raised IndexError, unlike a plain Toolset which delegates to a real list. Reuse __iter__ via list(self)[index] so indexing behaves consistently with a list of Tools, as documented. Fixes deepset-ai#11759
immuhammadfurqan
requested review from
julian-risch
and removed request for
a team
|
@immuhammadfurqan is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
|
|
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Toolsetis documented as implementing the collection interface (__iter__,__contains__,__len__,__getitem__) so it "behaves like a list of Tools."Toolset.__getitem__delegates to a real list, so negative indices work. But_ToolsetWrapper(returned when combiningToolsets with+) only did a forwardenumeratescan in__getitem__, socombined[-1]always raisedIndexError, breaking that documented contract as soon as two toolsets are combined.This PR changes
_ToolsetWrapper.__getitem__to materializelist(self)(reusing the existing__iter__, which already flattens all wrapped toolsets) and index into that, so it behaves exactly like a list, including negative indices and the standard out-of-rangeIndexError.How did you test it?
Added a regression test covering positive indices, negative indices, and the out-of-range case on a wrapper created by combining two
Toolsets. Ran the fulltest/tools/test_toolset_wrapper.pyandtest/tools/test_toolset.pysuites (23 passed),ruff check/ruff format, andmypy— all clean.Notes for the reviewer
None.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.