Skip to content

chore: Add type checking to test/human_in_the_loop, test/evaluation, test/document_stores and test/dataclasses#11285

Merged
sjrl merged 2 commits into
deepset-ai:mainfrom
maxdswain:more-test-type-checking
May 12, 2026
Merged

chore: Add type checking to test/human_in_the_loop, test/evaluation, test/document_stores and test/dataclasses#11285
sjrl merged 2 commits into
deepset-ai:mainfrom
maxdswain:more-test-type-checking

Conversation

@maxdswain
Copy link
Copy Markdown
Contributor

Related Issues

Proposed Changes:

This PR adds type checking to test/human_in_the_loop, test/evaluation, test/document_stores and test/dataclasses.

How did you test it?

Re-ran unit, integration and type checking tests.

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@maxdswain maxdswain requested a review from a team as a code owner May 10, 2026 14:44
@maxdswain maxdswain requested review from julian-risch and removed request for a team May 10, 2026 14:44
@vercel
Copy link
Copy Markdown

vercel Bot commented May 10, 2026

@maxdswain is attempting to deploy a commit to the deepset Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  haystack/core/pipeline
  async_pipeline.py
Project Total  

This report was generated by python-coverage-comment-action

@sjrl sjrl requested review from sjrl and removed request for julian-risch May 12, 2026 11:30
@sjrl sjrl self-assigned this May 12, 2026
@sjrl sjrl added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label May 12, 2026
Copy link
Copy Markdown
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sjrl sjrl merged commit c57397f into deepset-ai:main May 12, 2026
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:build/distribution topic:tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants