docs(ollama): add tool-calling example to integration landing page#473
Open
albertodiazdurana wants to merge 3 commits into
Open
docs(ollama): add tool-calling example to integration landing page#473albertodiazdurana wants to merge 3 commits into
albertodiazdurana wants to merge 3 commits into
Conversation
Closes deepset-ai/haystack-core-integrations#3263. Adds a minimal OllamaChatGenerator + Tool example to the Ollama integration landing page so practitioners can discover that local tool calling is supported. Verified empirically with llama3.1:8b on Ollama. Streaming-with-tools and tool_choice are deferred to the component reference page.
This was referenced May 6, 2026
kacperlukawski
requested changes
May 15, 2026
Comment on lines
+180
to
+185
| def get_weather(city: str) -> str: | ||
| """Get current weather for a city.""" | ||
| return f"Sunny, 22°C in {city}" | ||
|
|
||
|
|
||
| weather_tool = create_tool_from_function(get_weather) |
Member
There was a problem hiding this comment.
Could you please use a tool decorator instead of create_tool_from_function?
Address @kacperlukawski review on deepset-ai#473: replace create_tool_from_function with the @tool decorator, which matches the idiomatic form documented in haystack/tools/from_function.py. Verified empirically against ollama llama3.1:8b: the updated snippet emits ToolCall(tool_name='get_weather', arguments={'city': 'Berlin'}, ...). Net: -4 / +3 lines on integrations/ollama.md.
Author
|
Thanks @kacperlukawski. Replaced |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes deepset-ai/haystack-core-integrations#3263.
This adds a minimal tool-calling example to the Ollama integration
landing page (
integrations/ollama.md). Practitioners landing on thepage can now see that
OllamaChatGeneratorsupports local tool calling.The example uses
create_tool_from_function(the current public helperper haystack 2.x) and sets
temperature=0.0+ a directive prompt forreliable tool-call emission on Llama 3.1 8B; both are needed for
reproducibility, verified empirically.
Streaming-with-tools and
tool_choiceare deferred to the componentreference page (
docs.haystack.deepset.ai/docs/ollamachatgenerator),as agreed in the issue thread.