Refactor: replace the JSON path walker with schema operations - #7994
Merged
Merged
Conversation
mohanchen
added
Compile & CICD & Docs & Dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR further simplifies the JSON workflow after #7979 by removing the custom
jsonKeyNodepath abstraction and generic JSON walker, and using nativenlohmann::ordered_jsonoperations directly against the ABACUS output schema.AbacusJsonis reduced to document ownership and serialization, whileinit,general_info, andoutputnow manage their own schema-specific updates and validation. The existing strict output-record lifecycle checks are preserved, tests are reduced to ABACUS-specific behavior rather than re-testing generic JSON operations, and the JSON developer documentation is updated accordingly. Overall, this removes a substantial amount of migration-era abstraction without changing the intendedabacus.jsonschema.