Remove unused cereal JSON archive - #7993
Merged
Merged
Conversation
16 tasks
ZhouXY-PKU
approved these changes
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #7979. This should fix Intel Docker building failure, and get rid of #4947.
With #7979 ABACUS no longer uses RapidJSON, but still
#include <cereal/archives/json.hpp>, where Cereal relies on RapidJSON to work. Removing the main-branch RapidJSON branch installation has made cereal's JSON archive use system-installed RapidJSON-v1.1.0 and triggered bug Tencent/rapidjson#2347. Since ABACUS does not use cereal's JSON archive at all, this PR simply removes the unused inclusion.