Fix(deltaspin): memory leak error of deltaspin for nspin=4 - #7978
Merged
mohanchen merged 1 commit intoSep 17, 2026
Merged
Conversation
…ization reset_dspin_operator() sets DeltaSpin::initialized=false, so the next cal_pre_HR() runs again on the same operator. It called pre_hr.clear() on a vector of raw HContainer pointers, which does not free the pointed-to objects, and it never reset B_I_data. In DFT+U+DeltaSpin LCAO runs (where reset_dspin_operator() is called when the constraints change) this leaked memory linearly with the number of reinitializations. Delete the old HContainers before clearing pre_hr, and clear/resize B_I_data so unconstrained atoms do not keep stale overlap data. Fixes deepmodeling#6524.
mohanchen
added
collinear/non-collinear/SOC/delta-spin
mohanchen
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Free pre_hr/B_I_data caches on cal_pre_HR() reinitialization
reset_dspin_operator() sets DeltaSpin::initialized=false, so the next cal_pre_HR() runs again on the same operator. It called pre_hr.clear() on a vector of raw HContainer pointers, which does not free the pointed-to objects, and it never reset B_I_data. In DFT+U+DeltaSpin LCAO runs (where reset_dspin_operator() is called when the constraints change) this leaked memory linearly with the number of reinitializations.
Delete the old HContainers before clearing pre_hr, and clear/resize B_I_data so unconstrained atoms do not keep stale overlap data.
Fixes #6524.
Unit Tests and/or Case Tests for my changes
What's changed?
Governance Notes