Refactor charge density module (Useful Information for Refactoring a Module) - #7972

Merged

mohanchen merged 111 commits into

deepmodeling:developfrom

mohanchen:20260916

Sep 21, 2026

Commits on Sep 16, 2026

module_charge: normalize indentation and brace single-statement control flow
abacus_fixer
committed
83eb5d0
module_charge: aggregate Charge_Mixing params into MixingConfig
abacus_fixer
committed
aa9e515
module_charge: deduplicate twobeta_mix lambdas and replace raw new with std::vector
abacus_fixer
committed
589e65f
module_charge: move residual/inner-product globals into MixingConfig
abacus_fixer
committed
8246456
module_charge: own Charge's _space_* storage with std::vector (Step 5a)
abacus_fixer
committed
ecf5084
module_charge: route chgmixing_ks through its inp parameter
abacus_fixer
committed
25bd441
module_charge: split Charge::init_rho into per-stage private methods
abacus_fixer
committed
1e9411c
module_charge: extract Charge density math into charge_math free functions
abacus_fixer
committed
c4a8ed2
module_charge: register charge_math.o in the hand-written Makefile build
abacus_fixer
committed
e074dd0
Merge branch 'develop' into 20260916
mohanchen
authored
aab8b0e
module_charge: extract Charge::atomic_rho into charge_atomic free function
abacus_fixer
committed
7b346dc
module_charge: forbid Charge copies and guard tau.cube write
abacus_fixer
committed
0c7109d
module_base: tolerate null grid buffer when a rank owns no grid points
abacus_fixer
committed
871f8f2
module_charge: extract Charge::set_rho_core into charge_math free function
abacus_fixer
committed
1d3beac
module_charge: vectorize Charge_Extra history arrays and forbid copies
abacus_fixer
committed
49b0a65

Commits on Sep 17, 2026

Rename charge_math to chg_tools and unify namespace module_charge
abacus_fixer
committed
e0480f3
module_charge: refactor Symmetry_rho class to free functions
abacus_fixer
committed
5154f98
module_charge: extract MixingConfig header and drop unused inner_product_recip_simple
abacus_fixer
committed
dfbf99d
module_gint: move gint_prec_ctrl from module_charge
abacus_fixer
committed
619029d
module_charge: extract mixing inner products into chg_drho free functions
abacus_fixer
committed
2ac0017
module_charge: hide cal_drho/cal_dkin in an anonymous namespace
abacus_fixer
committed
61c2529
module_gint: fix include path in test_gint_prec_ctrl after relocation
abacus_fixer
committed
dfe1dac
module_charge: extract Kerker screen kernels into chg_precond free functions
abacus_fixer
committed
6d127d5
module_charge: fix Makefile.Objects after mix_precond -> chg_precond rename
abacus_fixer
committed
e4e6fc9
module_charge: drop Charge_Mixing::get_drho/get_dkin wrappers
abacus_fixer
committed
9a96847
module_charge: rename chgmixing.h/cpp to chg_routine.h/cpp
abacus_fixer
committed
c89aba3
module_charge: rename mixing_config.h to chg_mix_cfg.h
abacus_fixer
committed
ae65748
module_charge: convert Charge MPI helpers into chg_parallel free functions
abacus_fixer
committed
c531ea4
Rename charge_atomic files to chg_atomic
abacus_fixer
committed
b976259
module_charge: extract USPP double-grid split/merge into chg_uspp free functions
abacus_fixer
committed
2f49955
module_charge: rewrite MixDivCombTest for the new split_dgrid/merge_dgrid
abacus_fixer
committed
4650306
module_charge: drop legacy divide_data/combine_data/clean_data members
abacus_fixer
committed
2670f86

Commits on Sep 18, 2026

module_charge: rename charge_extra files to chg_extra and move class into namespace
abacus_fixer
committed
e4f111f
module_charge: extract DMR mixing into chg_dmr free functions
abacus_fixer
committed
570dd49
module_charge: remove Charge_Mixing DMR wrappers, call chg_dmr directly
abacus_fixer
committed
86b4f54
module_charge: decouple chg_dmr kernel from HContainer, mix raw buffers
abacus_fixer
committed
6d174ff
module_charge: refactor charge_mixing_rho free functions and cleanup
abacus_fixer
committed
d9685d4
module_charge: split member functions into charge_mixing.cpp, free functions into chg_rho_detail.h
abacus_fixer
committed
36da8fd
module_charge: rename charge_{init,mixing_rho} to chg_{init,tau}, widen cube_io ofs_running to ostream
abacus_fixer
committed
426c572
module_charge: rename charge_mixing.{h,cpp} to chg_mix.{h,cpp}, test to test_chg_mix.cpp
abacus_fixer
committed
1663581
module_charge: remove duplicate doc block comments (Phase 1a)
abacus_fixer
committed
3540a2b
module_charge: replace auto with explicit std::function types (Phase 1b)
abacus_fixer
committed
da75e2e
module_charge: wrap lines over 120 chars (Phase 1c)
abacus_fixer
committed
9038abd
module_charge: remove default parameter from Charge::init_rho (Phase 1d)
abacus_fixer
committed
a770ca7
module_charge: replace raw new/delete with std::vector and unique_ptr (Phase 2a-2d)
abacus_fixer
committed
0dc34cf
module_charge: replace raw new/delete in Charge with vector-backed storage (Phase 2e)
abacus_fixer
committed
962b0b3
module_charge: replace std::make_unique with C++11-compatible unique_ptr(new T) (fix)
abacus_fixer
committed
03e3e5e
module_charge: fix duplicate doc block in charge.cpp init_final_scf
abacus_fixer
committed
fd38f2c
module_charge: aggregate chgmixing_ks parameters into ScfMixingCtx struct (Phase 3a)
abacus_fixer
committed
73eee04
module_charge: aggregate read_rho_file/read_kin_file parameters into ReadCfg (Phase 3b)
abacus_fixer
committed
b8cb59d
module_charge: aggregate non_linear_core_correction parameters into NlcCtx (Phase 3c)
abacus_fixer
committed
b96b143
module_charge: split chg_mix.cpp into init and rho mixing files (Phase 4a)
abacus_fixer
committed
48866d9
module_charge: split chg_drho.cpp and decompose inner product functions (Phase 4b)
abacus_fixer
committed
23f12da
refactor(module_charge): split atomic_rho and remove ZEROS in charge mixing
abacus_fixer
committed
872f6d1
Refactor: remove redundant Charge& overload of cal_rhog_symm_soc
abacus_fixer
committed
2411e80
module_charge: fix stale TITLE/timer labels and drop unused xc_functional.h includes
abacus_fixer
committed
0b8dfbe
module_charge: remove redundant #ifdef __MPI guards around parallel wrappers
abacus_fixer
committed
7a00138
module_charge: decouple chg_routine from spin_constrain singleton
abacus_fixer
committed
a669eea
module_charge: remove PARAM dependencies via explicit configuration structs
abacus_fixer
committed
c9ba84b
Merge branch 'develop' into 20260916
mohanchen
authored
2d3592a
module_charge: restore #ifdef __MPI guards around parallel wrapper calls
abacus_fixer
committed
4dcbd1c
Remove dead PAW compensation charge members
abacus_fixer
committed
65252c4
Refactor: remove unused Charge::prenspin member
abacus_fixer
committed
6a67c09
Refactor: move Charge::cal_rho2ne/check_rho to module_charge free functions
abacus_fixer
committed
f489a13
Refactor: remove redundant Charge::omega_ pointer
abacus_fixer
committed
34b441e
Remove dead Charge::init_final_scf and allocate_rho_final_scf
abacus_fixer
committed
07ebcc1
Refactor: pass rhopw explicitly to chg_init/chg_routine/chg_extra/chg_symm
abacus_fixer
committed
1e492e5
Comments: add TODOs for LCAO+USPP double-grid follow-ups
abacus_fixer
committed
58c7fe4

Commits on Sep 19, 2026

Refactor: replace sticky Charge::cal_elf flag with explicit symm_kin argument
abacus_fixer
committed
a1fc87f
Refactor: resolve mixing_tau at config assembly, drop XC dependency from chg_mix
abacus_fixer
committed
87b818f
Fix: restore complete types in chg_drho_inner.cpp after include removal
abacus_fixer
committed
ee70805
Refactor: derive tau symmetrization/reduction from kin_r buffer existence
abacus_fixer
committed
dbf9d50
Refactor: remove module_xc dependency from module_charge (meta_gga state)
abacus_fixer
committed
ecf8418
Fix: allow null rho buffers on ranks with empty real-space grid partition
abacus_fixer
committed
25f51c5
Refactor: move rhog_io into module_charge as chg_rhog_io
abacus_fixer
committed
1528e79
Refactor: create module_charge/test with the rhog io unit test
abacus_fixer
committed
15f7026
Refactor: move charge and charge-extra unit tests into module_charge/test
abacus_fixer
committed
3b66374
Refactor: move mix, parallel and tools unit tests into module_charge/test
abacus_fixer
committed
eeb2740
Refactor: rename module_charge test dir to unittests and wire CI for it
abacus_fixer
committed
ff766ac
Fix: pass ucell.omega to Charge::sum_rho/renormalize_rho to fix NPT stress
abacus_fixer
committed
ce50549
Fix: add omega arg to remaining dm2rho call sites
abacus_fixer
committed
140be65
Fix: restore HamiltHSMatrix hs declaration in cal_mw_from_lambda
abacus_fixer
committed
46a9665
Merge branch 'develop' into 20260916
mohanchen
authored
cc3a0af

Commits on Sep 20, 2026

Merge branch 'develop' into 20260916
Critsium-xy
authored
0088c1d
Fix: close_kerker_gg0 actually disables Kerker; drop dead mixing_gg0 members
abacus_fixer
committed
431f9a3
Fix: relax over-strict null-buffer asserts for empty grid partitions
abacus_fixer
committed
03b47a7
Fix: relax over-strict null-buffer assert in ParaRgridWorld::reduce_across_pools
abacus_fixer
committed
01000c6
Fix: allow nnr == 0 in DMR mixing for empty MPI partitions
abacus_fixer
committed
7ba427c
Fix: split reciprocal rho copy from real-space |m| rescale in mix_rho_recip
abacus_fixer
committed
4e3966e
Refactor: remove unused Charge_Mixing::conserve_setting
abacus_fixer
committed
22391b3
Refactor: drop dead Charge_Mixing::tpiba2 member
abacus_fixer
committed
4424915
Refactor: route Charge_Mixing getters through cfg_
abacus_fixer
committed
b01a330
Refactor: init_mixing constructs Mixing from cfg_ not legacy mirrors
abacus_fixer
committed
f2e4685
Refactor: mix_rho_recip/mix_rho_real read mixing_beta from cfg_
abacus_fixer
committed
ce98bd5
Refactor: set_mixing stops mirroring cfg_ into legacy members
abacus_fixer
committed
60a7586
Refactor: drop legacy Charge_Mixing mirror members; cfg_ is single source
abacus_fixer
committed
6c0c079
Refactor: drop NSDMI from MixingConfig to force explicit construction
abacus_fixer
committed
52593de
Refactor: aggregate-init MixingConfig in esolver_ks with pragma guard
abacus_fixer
committed
c14afdd
Refactor: aggregate-init MixingConfig in test_chg_mix with pragma guard
abacus_fixer
committed
ca5a30f
Merge branch '20260916' of github.com:mohanchen/abacus-mc into 20260916
abacus_fixer
committed
dd2d478
Fix: fail-fast guards in Charge_Mixing and update chg_mix tests
abacus_fixer
committed
dfaefdf
test(module_charge): add unit tests for chg_uspp and chg_dmr
abacus_fixer
committed
8cbc558
test(module_charge): add unit tests for chg_precond, chg_drho, chg_drho_inner, chg_mix_rho
abacus_fixer
committed
68e820f
test(module_charge): add unit tests for chg_symm, chg_symm_detail, chg_atomic, chg_atomic_inner
abacus_fixer
committed
f10bd03
test(module_charge): add chg_tau/chg_routine/chg_init tests; drop spurious XC_Functional stubs
abacus_fixer
committed
35bf4fe
test(module_charge): fix broken includes in unit tests
abacus_fixer
committed
5b9f83a
test(module_charge): fix link/build issues; temporarily disable routine/init targets
abacus_fixer
committed
a04584f
fix bug
abacus_fixer
committed
b2fca4e

Commits on Sep 21, 2026

format tool_quit
abacus_fixer
committed
6e8708e
remove a test due to WARNING_QUIT funcitno
abacus_fixer
committed
2530392
delete the support file charge-density.dat because unittests never need it
abacus_fixer
committed
ce9271d