fix: parse pipelined redis messages#11827
Open
hengyoush wants to merge 1 commit into
Open
Conversation
hengyoush
marked this pull request as ready for review
July 24, 2026 03:48
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for:
Fixes #11828
Redis L7 logs are missing for pipelined messages coalesced into a single TCP payload.
Steps to reproduce the bug
Root cause
The Redis parser tracked request state with a single boolean and decoded only one top-level RESP message per payload. Redis pipelining can place multiple commands or responses in the same TCP payload, so messages after the first were skipped.
Changes to fix the bug
Affected branches
Checklist
Validation
cargo test --lib flow_generator::protocol_logs::sql::redis::tests -- --nocapture(11 passed)cargo fmt --all -- --checkRUSTFLAGS='-D warnings -C force-frame-pointers=yes' cargo check --all-targets