fix(vm): keep target PVC when migrating VM with local disks (release 1.9)#2522
Merged
loktev-d merged 1 commit intoJun 23, 2026
Merged
Conversation
loktev-d
requested review from
Isteb4k,
diafour,
fl64,
goganat,
nevermarine,
prismagod,
universal-itengineer and
yaroslavborbat
as code owners
Two fixes making live migration / Evict of VMs with hotplugged local-storage disks reliable. Follow-up to #2508. 1. vm controller: stable volume swap. The migration volume/affinity were gated on the VD Migrating condition, which is False (WaitForTargetReady) until the target PVC binds. Mid-migration the controller read that as "not migrating" and reverted the hotplug volume/affinity to the source PVC. Now gated on the stable MigrationState. 2. vd controller: no stale target PVC. Back-to-back migrations could adopt a previous migration's still-terminating PVC as the target. Now terminating non-source PVCs are filtered out, so a fresh target is created. --------- Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
loktev-d
force-pushed
the
fix/vm/local-disk-migration-volume-revert-1.9
branch
from
566987a to
e6dece1
Compare
danilrwx
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two fixes making live migration / Evict of VMs with hotplugged local-storage disks reliable. Follow-up to #2508.
Why do we need it, and what problem does it solve?
VMs with local-storage hotplug disks couldn't be reliably evicted/migrated.
What is the expected result?
Repeatedly Evict a VM with a hotplug disk on a local WFC storage class - target launcher and attachment pod schedule on the target node and the migration completes; no Unschedulable, no WaitForTargetReady stall.
Checklist
Changelog entries