Skip to content

test(vm): enable "should be reverted first and completed second" migration case#2271

Merged
yaroslavborbat merged 1 commit intomainfrom
test/enable-local-disks-test
Apr 30, 2026
Merged

test(vm): enable "should be reverted first and completed second" migration case#2271
yaroslavborbat merged 1 commit intomainfrom
test/enable-local-disks-test

Conversation

@yaroslavborbat
Copy link
Copy Markdown
Member

@yaroslavborbat yaroslavborbat commented Apr 24, 2026

Description

Enables the migration test:

should be reverted first and completed second

Why do we need it, and what problem does it solve?

This test was flaky/failing because migration cancel could leave a concluded block job in QEMU.
When that happened, subsequent migration attempts could not start (stale block-migration job state after abort).

Now we enable this test to validate the fix path for cancel/retry behavior and protect against regressions.

What is the expected result?

  1. Run migration test suite including should be reverted first and completed second.
  2. Test should pass consistently.
  3. No intermittent failures caused by lingering concluded block jobs after migration cancel.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@yaroslavborbat yaroslavborbat added this to the v1.9.0 milestone Apr 24, 2026
@yaroslavborbat yaroslavborbat force-pushed the test/enable-local-disks-test branch from 0960ce9 to aa1e0bf Compare April 27, 2026 13:59
@yaroslavborbat yaroslavborbat changed the base branch from main to feat/vm/abort-block-jobs April 27, 2026 13:59
@yaroslavborbat yaroslavborbat force-pushed the feat/vm/abort-block-jobs branch from 733dc2d to 45920b4 Compare April 27, 2026 14:39
@yaroslavborbat yaroslavborbat force-pushed the test/enable-local-disks-test branch from aa1e0bf to 0fb3a82 Compare April 27, 2026 14:42
@yaroslavborbat yaroslavborbat force-pushed the feat/vm/abort-block-jobs branch 2 times, most recently from ca8561d to eb309a4 Compare April 29, 2026 12:37
@yaroslavborbat yaroslavborbat force-pushed the test/enable-local-disks-test branch 3 times, most recently from d64685b to 6b8a510 Compare April 29, 2026 12:52
@yaroslavborbat yaroslavborbat force-pushed the feat/vm/abort-block-jobs branch from eb309a4 to 321a624 Compare April 29, 2026 12:53
@yaroslavborbat yaroslavborbat force-pushed the test/enable-local-disks-test branch from 6b8a510 to f88b2ac Compare April 29, 2026 12:54
@yaroslavborbat yaroslavborbat changed the title enable test test(vm): enable "should be reverted first and completed second" migration case Apr 29, 2026
@yaroslavborbat yaroslavborbat marked this pull request as ready for review April 29, 2026 12:59
@yaroslavborbat yaroslavborbat force-pushed the test/enable-local-disks-test branch 2 times, most recently from 71ef15c to 97214c5 Compare April 29, 2026 13:08
diafour
diafour previously approved these changes Apr 29, 2026
Base automatically changed from feat/vm/abort-block-jobs to main April 30, 2026 13:27
@yaroslavborbat yaroslavborbat dismissed diafour’s stale review April 30, 2026 13:27

The base branch was changed.

Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>
@yaroslavborbat yaroslavborbat force-pushed the test/enable-local-disks-test branch from 97214c5 to 3711319 Compare April 30, 2026 13:38
@yaroslavborbat yaroslavborbat merged commit f706ed2 into main Apr 30, 2026
22 of 23 checks passed
@yaroslavborbat yaroslavborbat deleted the test/enable-local-disks-test branch April 30, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants