feat(vm): surface the “No bootable device” error in the VM#2183
Draft
feat(vm): surface the “No bootable device” error in the VM#2183
Conversation
eofff
force-pushed
the
chore/vm/bootable-experiments
branch
5 times, most recently
from
005d35b to
53e1b60
Compare
Contributor
|
Workflow has started. The target step completed with status: failure. |
eofff
changed the title
eofff
force-pushed
the
chore/vm/bootable-experiments
branch
from
5f2aa5f to
9c44bf7
Compare
eofff
requested review from
Isteb4k,
nevermarine,
universal-itengineer and
yaroslavborbat
as code owners
diafour
reviewed
Apr 10, 2026
Comment on lines
+103
to
+104
| echo "Applying $p" | ||
| git apply "$p" |
Member
There was a problem hiding this comment.
Suggested change
| echo "Applying $p" | |
| git apply "$p" | |
| echo -n "Apply ${p} ... " | |
| git apply --ignore-space-change --ignore-whitespace ${p} && echo OK || (echo FAIL ; exit 1) |
For consistency with other images.
eofff
force-pushed
the
chore/vm/bootable-experiments
branch
from
5b051fc to
87bdc15
Compare
eofff
force-pushed
the
chore/vm/bootable-experiments
branch
2 times, most recently
from
082756c to
ae12b04
Compare
eofff
force-pushed
the
chore/vm/bootable-experiments
branch
from
0b2101b to
69a9a6a
Compare
added 4 commits
April 29, 2026 13:12
added 20 commits
April 29, 2026 13:12
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
eofff
force-pushed
the
chore/vm/bootable-experiments
branch
from
69a9a6a to
5228d6e
Compare
added 3 commits
April 29, 2026 13:39
diafour
reviewed
Apr 29, 2026
| CharBackend chr; | ||
| uint32_t readback; | ||
| + bool watch_no_bootable_device; | ||
| + char match_buf[sizeof(DEBUGCON_NO_BOOTABLE_DEVICE) - 1]; |
Member
There was a problem hiding this comment.
It seems there is no need to decrease size for buf length, sizeof is OK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Surface the “No bootable device” error in the VM.
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist
Changelog entries