[module-sdk] expose readonly Settings on ApplicationHookInput#103
Merged
Conversation
dba5505 to
71f84d4
Compare
Signed-off-by: Artem Kuleshov <artem.kuleshov@flant.com>
71f84d4 to
3c66808
Compare
Signed-off-by: Artem Kuleshov <artem.kuleshov@flant.com>
ipaqsa
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a readonly Settings field to ApplicationHookInput, symmetrical to how module hooks receive ConfigValues. Typed as pkg.ReadableValuesCollector (no Set/Remove). Reuses the existing CONFIG_VALUES_PATH channel — no new env var, no addon-operator changes.
Example hook:
Unit test in main_test.go covers both branches (gate closed → Values.Set not called; gate open → called with expected pods).
Cluster-verified on a live Deckhouse cluster via artem-test, gating on triggersEnabled: