[deckhouse-cli] Fix pull tests leaving bundle artifacts #342
Open
Glitchy-Sheep wants to merge 1 commit intomainfrom
Open
[deckhouse-cli] Fix pull tests leaving bundle artifacts #342Glitchy-Sheep wants to merge 1 commit intomainfrom
Glitchy-Sheep wants to merge 1 commit intomainfrom
Conversation
- `newPullService` now allocates a `t.TempDir()` when `BundleDir` is empty, so tests don't drop artifacts into the working tree. Signed-off-by: Roman Berezkin <roman.berezkin@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[mirror] Fix pull tests leaving bundle artifacts in the working tree
Summary
Pull tests called
newPullServicewithout settingBundleDir, so eachgo testrun dropped bundle files into the repo working tree instead of a temp dir.Fix
newPullServicenow fillsBundleDirwitht.TempDir()when callers leave it empty (and creates the options struct ifnil).Tests that need a specific path still override it.
Before / After
Before:
go test ./internal/mirror/...left untracked bundle files in the working tree.After: Each test gets its own
t.TempDir(), cleaned up by Go automatically.