Support partial-hand deals in CalcDDtable and dtest tooling

[tameware]

Summary

• Fix CalcDDtable / solver trick counting for deals with fewer than 13 cards per hand.
• Add --cards to create_list_for_dtest and forward it from regenerate_hand_lists.sh.
• Add generate_partial_hands_lists.sh and ignore generated hands/partial/ outputs.

Test plan

• bazelisk test //library/tests/system:calc_dd_table_partial_test
• bazelisk test //python/utilities:create_list_for_dtest_test
• Generate partial lists and run dtest against a fewer-than-13-card deal file

Made with Cursor

[tameware]

There's more to be done here, in particular having the PAR lines make sense. This is ready to merge now, though. It's an improvement over what preceded it, where dtest accepted deals of fewer than 12 cards but the TABLE line was incorrect. If I continue without merging then the PR will get bigger than I'd like.

[Copilot]

Pull request overview

This PR extends DDS tooling and the DD-table calculation paths to correctly handle partial bridge deals (fewer than 13 cards per hand), and adds scripts/tests to generate and validate those partial-hand deal lists.

Changes:

• Fix DD-table trick conversion and null-window bounds so results are computed out of remaining tricks instead of assuming 13.
• Add --cards support to create_list_for_dtest and forward it from hand-list regeneration scripts; add a helper script to generate all partial-hand lists.
• Add a system regression test covering CalcDDtable behavior on a 1-card-per-hand deal and wire it into Bazel.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
utilities/src/regenerate_hand_lists.sh	Adds --cards arg parsing and forwards it to the list generator.
utilities/src/generate_partial_hands_lists.sh	New helper script to generate hands/partial/* lists for 1–12 cards/hand.
python/utilities/src/create_list_for_dtest.py	Adds --cards, generates partial deals, and updates play generation to iterate over total remaining cards.
python/utilities/tests/create_list_for_dtest_test.py	Adds unit coverage for --cards parsing and partial dealing behavior.
library/src/solver_if.cpp	Bounds solve_same_board search to remaining tricks (not hardcoded 13).
library/src/calc_tables.cpp	Computes remaining tricks from holdings; uses it when converting leader-side score into declarer tricks; avoids 13 - score assumptions.
library/tests/system/calc_dd_table_partial_test.cpp	New regression test ensuring CalcDDtable variants report tricks out of remaining cards.
library/tests/system/BUILD.bazel	Registers the new system test.
.gitignore	Ignores generated hands/partial/ outputs.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[tameware]

Addressed the --cards forwarding comment: regenerate_hand_lists.sh now builds an argv array so --cards and its value are separate arguments.

[tameware]

Addressed remaining review comments:

• Fixed “aremainly” typo in generate_partial_hands_lists.sh
• Resolve repo root from script dir and quote path expansions
• Added test_main_with_cards_writes_play_line_with_four_times_cards

[Copilot]

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

utilities/src/generate_partial_hands_lists.sh:22

• The final mv makes this script non-idempotent (re-running after a successful run will fail if 01_card/ already exists, and it also fails if a previous run already moved 01_cards/). Prefer generating the desired directory name in the loop instead of renaming afterward.

    ./utilities/src/regenerate_hand_lists.sh \
    --cards "$CARDS"
done

mv "${PARENT_DIR}/01_cards/" "${PARENT_DIR}/01_card/"

[tameware]

Addressed the CalcDDtable performance comment: restored solve_same_board for full 13-trick deals; partial deals still use full solve_board per leader.

[tameware]

Addressed: bare --cards now errors with “Missing value for --cards (expected 1–13)” instead of an unbound-variable failure under set -u.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated no new comments.

Suppressed comments (2)

Previously missed (2) — in code that hasn't changed since the last review.

utilities/src/generate_partial_hands_lists.sh:22

• The final mv is not safe to rerun: if ${PARENT_DIR}/01_card/ already exists, mv .../01_cards/ .../01_card/ will nest the directory (01_card/01_cards) instead of replacing it.

mv "${PARENT_DIR}/01_cards/" "${PARENT_DIR}/01_card/"

utilities/src/regenerate_hand_lists.sh:20

• --cards assumes a following value ($2) without checking it exists. With set -u, calling the script as ... --cards will abort with an unhelpful “unbound variable” error instead of a clear message.

    --cards)
      if [[ $# -lt 2 ]]; then
        echo "Missing value for --cards (expected 1–13)" >&2
        exit 1

[tameware]

Addressed the suppressed comments from the latest review:

• generate_partial_hands_lists.sh: rm -rf the destination before renaming 01_cards → 01_card so reruns do not nest.
• --cards without a value was already fixed earlier (Missing value for --cards… under set -u).

[Copilot]

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated no new comments.

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

library/src/calc_tables.cpp:61

• The legacy C++ convenience wrapper calc_dd_table* still hardcodes 13 - solved...score[...] (see library/src/calc_dd_table.cpp:70-72), so partial-hand deals will still return impossible trick counts through that API even though the C APIs in this file now use remaining_tricks_from_holdings(). This leaves the PR’s “Support partial-hand deals in CalcDDtable” incomplete for C++ callers.

auto declarer_tricks_from_leader_score(
  int remaining_tricks,
  int leader_side_score) -> int
{
  return remaining_tricks - leader_side_score;
}

[tameware]

Addressed the suppressed comment: C++ calc_dd_table / calc_dd_table_pbn now use remaining_tricks_from_holdings() instead of hardcoded 13 - score. Added CalcDdTablePartialCpp regression test.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated no new comments.