Enable Bazelisk Caching. - #343
Conversation
|
I see the latest Windows run was 17 minutes. Is that faster than before the change? Do we have access to a log of build duration over time? |
|
Claude checked build times so there must be a log somewhere, but I need to find out where it is. |
There was a problem hiding this comment.
Pull request overview
This PR aims to speed up CI by enabling caching in the shared Bazelisk setup composite action and by reordering the Linux CI steps so default-configuration work (including the .NET binding tests and full test run) happens before non-default Bazel flag builds.
Changes:
- Enable Bazel action/repository caching via
bazel-contrib/setup-bazelin the sharedsetup-bazeliskcomposite action. - Reorder Linux CI steps to keep default-config build/test and .NET binding validation together before
--definebuilds that change the active output configuration. - Keep non-default
--definebuild/test steps grouped at the end for clarity and to avoid impacting steps that rely on the default configuration.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/ci_linux.yml | Reorders CI steps so default-config tasks run before non-default --define builds. |
| .github/actions/setup-bazelisk/action.yml | Enables disk-cache and repository-cache to persist build outputs and external repo downloads between CI runs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
My mistake! It seems so far the caching applies only to the Linux build. We should look into that one too, but my concern is always with the one that's gating throughput. |
Or at any rate, |
Yes, but is only changing the order of the steps to have those that similar things close to each other in the script. It was confusing to read. Speedup is expected for caching. |
Linux build_and_test was 20 minutes for the release branch. 14 minutes here. Maybe it did benefit from the caching? |
I hope so! Whenever I looked, Windows was the only one pushing 20 minutes. Cursor was helpful – the gh commands work nicely:
|
|
I believe the Windows run will benefit from the caching. I think the best way forward is to merge this and check CI run times once we have a bit more data. Do you agree @tameware? |
|
I do. Easy to roll back if need be. |
Caching downloads and some artefacts is expected to speed up our CI pipeline.