Skip to content

fix(drupal-core): install Drush via Guzzle alias while Drush lags core's Guzzle 8 bump #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rfay merged 1 commit into from
Jul 25, 2026
Merged

fix(drupal-core): install Drush via Guzzle alias while Drush lags core's Guzzle 8 bump #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion drupal-core/scripts/test-issue-branches.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,18 @@ for PAIR in "${TESTS[@]}"; do
ddev composer install 2>&1 || COMPOSER_EXIT=$?

if [ "$COMPOSER_EXIT" = "0" ]; then
ddev composer require drush/drush 2>&1 | tail -5
# Mirrors the Drush install in template.tf: fall back to an inline Guzzle
# alias while Drush still requires guzzlehttp/guzzle ^7.0 and core main
# requires ^8.0 (drush-ops/drush#6602).
DRUSH_EXIT=0
ddev composer require drush/drush > /tmp/drush-require.log 2>&1 || DRUSH_EXIT=$?
tail -5 /tmp/drush-require.log
if [ "$DRUSH_EXIT" != "0" ]; then
GUZZLE_VER=$(jq -r '.packages[] | select(.name == "guzzlehttp/guzzle") | .version' composer.lock 2>/dev/null || true)
case "$GUZZLE_VER" in
8.*) ddev composer require "guzzlehttp/guzzle:$GUZZLE_VER as 7.99.0" drush/drush -W 2>&1 | tail -5 ;;
esac
fi
fi

# --- Record result ---
Expand Down
31 changes: 29 additions & 2 deletions drupal-core/template.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,12 +922,39 @@ WELCOME_STATIC
if [ "$SETUP_FAILED" != "true" ]; then
log_setup "Adding Drush to composer.local.json..."
update_status "⏳ Drush install: In progress..."
_drush_ok=false
if ddev composer require drush/drush >> "$SETUP_LOG" 2>&1; then
_drush_ok=true
else
# Drush's Guzzle constraint lags core's. Core main moved to
# guzzlehttp/guzzle ^8.0 on 2026-07-24 (drupal.org issue #3612544)
# while every Drush version still requires ^7.0, so a plain
# `composer require drush/drush` is unsatisfiable against Drupal 12
# HEAD. Guzzle 8 works with Drush at runtime, so retry with an inline
# alias presenting the locked Guzzle version as a 7.x one. Composer
# only accepts an exact version as an alias source, hence reading it
# from composer.lock. Remove this fallback once Drush ships Guzzle 8
# support (drush-ops/drush#6602).
_guzzle_ver=$(jq -r '.packages[] | select(.name == "guzzlehttp/guzzle") | .version' composer.lock 2>/dev/null || true)
case "$_guzzle_ver" in
8.*)
log_setup "Drush/Guzzle constraint conflict — retrying with guzzle $_guzzle_ver aliased as 7.99.0..."
if ddev composer require "guzzlehttp/guzzle:$_guzzle_ver as 7.99.0" drush/drush -W >> "$SETUP_LOG" 2>&1; then
_drush_ok=true
fi
;;
esac
fi
if [ "$_drush_ok" = "true" ]; then
log_setup "✓ Drush installed"
update_status "✓ Drush install: Success"
else
log_setup "⚠ Warning: Failed to install Drush (non-critical)"
update_status "⚠ Drush install: Warning"
# Every later step (site install, cache rebuild, uli) runs through
# Drush, so treat this as fatal instead of emitting a cascade of
# "drush is not available" errors.
log_setup "✗ Failed to install Drush — cannot install Drupal without it"
update_status "✗ Drush install: Failed"
SETUP_FAILED=true
fi
fi
fi
Expand Down
Loading