Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
fetchvalue now returns raw value instead of string.
[v5.0.0] Breaking Changes
DBUtils.fetchvalue()andDBUtilsAsync.fetchvalue()now return the value with itsnative type. They previously coerced every result with
str().This is silent at import time: code that treated the result as a string (
.startswith(),== "1",datetime.fromisoformat(...), string concatenation) will now fail at runtime orbehave differently.
Migration. Where a string is genuinely wanted, coerce at the call site — and note that
a bare
str()turnsNoneinto the string"None":Code that parsed the result back into a real type can now drop the parsing:
fetchall()was already returning native types and is unaffected.Type of Change
Testing
Reviewer