Fix NVIDIA GLSL crash during ROM loading - #157
Closed
sabino wants to merge 0 commit into
Closed
Conversation
sabino
force-pushed
the
agent/fix-nvidia-glsl-rom-loading
branch
from
July 24, 2026 14:56
8fc2535 to
b36a345
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
GnGeo creates the OpenGL context on the main thread, but its ROM-loading progress worker also calls
screen_update(). NVIDIA's GL dispatch crashes when that worker tries to render through a context owned by another thread.The old progress worker already disabled rendering on macOS and MinGW for this reason, but Linux remained affected. The updated path renders progress from the caller thread and throttles updates to avoid slowing down ROM loading.
This reproduces the behavior reported in #35 on a current Linux/NVIDIA environment.
Validation
0.8.1+202606021654, NVIDIA driver580.159.03, and the three-passqcrt-flat.glslppreset: the process printedCatch a sigsegvduring ROM loading and exited255ngdevkitbranch with this patch