Skip to content

Configure uv package cooldown#55

Merged
dceoy merged 1 commit into
mainfrom
agent/configure-uv-cooldown
Jul 20, 2026
Merged

Configure uv package cooldown#55
dceoy merged 1 commit into
mainfrom
agent/configure-uv-cooldown

Conversation

@dceoy

@dceoy dceoy commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • configure a one-week dependency cooldown in pyproject.toml
  • preserve the Windows required-environment constraint
  • exempt only pdmt5 so its latest release can resolve immediately
  • keep pyright and all other third-party packages subject to the cooldown
  • regenerate uv.lock and update vulnerable click 8.3.1 to 8.4.2

Configuration

[tool.uv]
required-environments = ["platform_system == 'Windows'"]
exclude-newer = "1 week"
exclude-newer-package = { pdmt5 = false }

Validation

  • follows uv's documented dependency-cooldown configuration
  • uv.lock records the resolved cutoff, P1W span, and pdmt5 = false
  • pdmt5 is locked at 1.2.0
  • click is locked at 8.4.2, fixing PYSEC-2026-2132
  • the PR contains a single commit and changes only pyproject.toml and uv.lock

@dceoy dceoy closed this Jul 19, 2026
@dceoy
dceoy force-pushed the agent/configure-uv-cooldown branch from b44b5a8 to 4dafc20 Compare July 19, 2026 12:23
@dceoy dceoy reopened this Jul 19, 2026
@dceoy dceoy closed this Jul 19, 2026
@dceoy
dceoy force-pushed the agent/configure-uv-cooldown branch from 677af95 to 4dafc20 Compare July 19, 2026 13:35
@dceoy dceoy reopened this Jul 19, 2026
@dceoy dceoy closed this Jul 20, 2026
@dceoy
dceoy force-pushed the agent/configure-uv-cooldown branch from 91c9ec3 to 4dafc20 Compare July 20, 2026 15:12
@dceoy dceoy reopened this Jul 20, 2026
@dceoy
dceoy force-pushed the agent/configure-uv-cooldown branch from b122fe6 to 3000009 Compare July 20, 2026 15:40
@dceoy
dceoy force-pushed the agent/configure-uv-cooldown branch from 9f4f61e to 9b75548 Compare July 20, 2026 16:00
@dceoy
dceoy marked this pull request as ready for review July 20, 2026 17:56
@greptile-apps

greptile-apps Bot commented Jul 20, 2026

Copy link
Copy Markdown

Greptile Summary

This PR configures a one-week uv dependency cooldown in pyproject.toml and regenerates uv.lock accordingly, also updating click from 8.3.1 to 8.4.2 to address PYSEC-2026-2132.

  • Adds exclude-newer = \"1 week\" and exclude-newer-package = { pdmt5 = false } to [tool.uv] so all packages age for a week before the resolver can pick them up, while pdmt5 remains exempt to always resolve to its latest release.
  • Updates click to 8.4.2, fixing a known security advisory; pdmt5 is locked at 1.2.0 and metatrader5 stays at 5.0.5735.
  • The lock file also silently drops the sys_platform == 'win32' marker from metatrader5's numpy dependency — this is harmless given the Windows-only required-environments constraint, but was not mentioned in the PR description.

Confidence Score: 4/5

Safe to merge — changes are limited to dependency configuration and a lock file regeneration with no runtime code modifications.

The pyproject.toml change is straightforward and uses the correct uv syntax. The click security update is clearly beneficial. The only item worth a second look is the unannounced removal of the sys_platform == 'win32' marker on metatrader5's numpy dependency in the lock file; it appears benign given the Windows-only required-environments setting, but confirming it reflects upstream metadata rather than a resolver quirk would give full confidence.

uv.lock — specifically the metatrader5/numpy marker change at line ~437.

Important Files Changed

Filename Overview
pyproject.toml Adds uv exclude-newer = "1 week" cooldown and exempts pdmt5 via exclude-newer-package; preserves the Windows required-environments constraint. Configuration syntax is correct per uv docs.
uv.lock Regenerated lock file: adds cooldown options block, updates click 8.3.1 → 8.4.2 (security fix PYSEC-2026-2132), and silently drops the sys_platform == win32 marker from metatrader5's numpy dependency.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[uv resolve] --> B{Package released\nwithin last week?}
    B -- Yes --> C{Is package pdmt5?}
    B -- No --> E[Allow version]
    C -- Yes --> E
    C -- No --> D[Exclude version\ncooldown active]
    E --> F[Write to uv.lock]
    F --> G[click 8.4.2\nfixes PYSEC-2026-2132]
    F --> H[pdmt5 1.2.0\nexempt from cooldown]
    F --> I[All other deps\nsubject to 1-week cooldown]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[uv resolve] --> B{Package released\nwithin last week?}
    B -- Yes --> C{Is package pdmt5?}
    B -- No --> E[Allow version]
    C -- Yes --> E
    C -- No --> D[Exclude version\ncooldown active]
    E --> F[Write to uv.lock]
    F --> G[click 8.4.2\nfixes PYSEC-2026-2132]
    F --> H[pdmt5 1.2.0\nexempt from cooldown]
    F --> I[All other deps\nsubject to 1-week cooldown]
Loading

Fix All in Cursor Fix All in Claude Code Fix All in Codex

Reviews (1): Last reviewed commit: "Configure uv dependency cooldown" | Re-trigger Greptile

Comment thread uv.lock

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9b75548455

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pyproject.toml

@dceoy dceoy left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary

No actionable issues meeting the review’s reporting threshold were identified.

Checked

  • pyproject.toml cooldown configuration, preservation of the Windows required-environments constraint, and the pdmt5 exemption
  • uv.lock cooldown metadata, click 8.4.2 update, and the metatrader5/numpy marker change
  • Current-head CI for 9b755484554523a14a6e807baf8319b658624cc4
  • Existing review submissions and unresolved inline discussions to avoid duplicating already-reported concerns

Notes

  • The existing unresolved review thread about declaring a minimum uv version for relative cooldown syntax remains applicable and was not duplicated here.
  • The existing discussion of the regenerated metatrader5 dependency marker already covers that lockfile change.

Recommended Action

Address or disposition the existing uv-version compatibility thread before merging; no additional automated blocking concerns were identified.

@dceoy
dceoy merged commit 82173b2 into main Jul 20, 2026
7 checks passed
@dceoy
dceoy deleted the agent/configure-uv-cooldown branch July 20, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant