Configure uv package cooldown#55
Conversation
b44b5a8 to
4dafc20
Compare
677af95 to
4dafc20
Compare
91c9ec3 to
4dafc20
Compare
b122fe6 to
3000009
Compare
9f4f61e to
9b75548
Compare
Greptile SummaryThis PR configures a one-week uv dependency cooldown in
Confidence Score: 4/5Safe to merge — changes are limited to dependency configuration and a lock file regeneration with no runtime code modifications. The pyproject.toml change is straightforward and uses the correct uv syntax. The click security update is clearly beneficial. The only item worth a second look is the unannounced removal of the sys_platform == 'win32' marker on metatrader5's numpy dependency in the lock file; it appears benign given the Windows-only required-environments setting, but confirming it reflects upstream metadata rather than a resolver quirk would give full confidence. uv.lock — specifically the metatrader5/numpy marker change at line ~437. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[uv resolve] --> B{Package released\nwithin last week?}
B -- Yes --> C{Is package pdmt5?}
B -- No --> E[Allow version]
C -- Yes --> E
C -- No --> D[Exclude version\ncooldown active]
E --> F[Write to uv.lock]
F --> G[click 8.4.2\nfixes PYSEC-2026-2132]
F --> H[pdmt5 1.2.0\nexempt from cooldown]
F --> I[All other deps\nsubject to 1-week cooldown]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[uv resolve] --> B{Package released\nwithin last week?}
B -- Yes --> C{Is package pdmt5?}
B -- No --> E[Allow version]
C -- Yes --> E
C -- No --> D[Exclude version\ncooldown active]
E --> F[Write to uv.lock]
F --> G[click 8.4.2\nfixes PYSEC-2026-2132]
F --> H[pdmt5 1.2.0\nexempt from cooldown]
F --> I[All other deps\nsubject to 1-week cooldown]
Reviews (1): Last reviewed commit: "Configure uv dependency cooldown" | Re-trigger Greptile |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b75548455
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dceoy
left a comment
There was a problem hiding this comment.
PR Review Summary
No actionable issues meeting the review’s reporting threshold were identified.
Checked
pyproject.tomlcooldown configuration, preservation of the Windowsrequired-environmentsconstraint, and thepdmt5exemptionuv.lockcooldown metadata,click8.4.2 update, and themetatrader5/numpymarker change- Current-head CI for
9b755484554523a14a6e807baf8319b658624cc4 - Existing review submissions and unresolved inline discussions to avoid duplicating already-reported concerns
Notes
- The existing unresolved review thread about declaring a minimum uv version for relative cooldown syntax remains applicable and was not duplicated here.
- The existing discussion of the regenerated
metatrader5dependency marker already covers that lockfile change.
Recommended Action
Address or disposition the existing uv-version compatibility thread before merging; no additional automated blocking concerns were identified.
Summary
pyproject.tomlpdmt5so its latest release can resolve immediatelypyrightand all other third-party packages subject to the cooldownuv.lockand update vulnerableclick8.3.1 to 8.4.2Configuration
Validation
uv.lockrecords the resolved cutoff,P1Wspan, andpdmt5 = falsepdmt5is locked at 1.2.0clickis locked at 8.4.2, fixing PYSEC-2026-2132pyproject.tomlanduv.lock