Fix Statement.getUpdateCount: return -1 when current result is a ResultSet#54
Open
IceboxDev wants to merge 1 commit intodbeaver:develfrom
Open
Fix Statement.getUpdateCount: return -1 when current result is a ResultSet#54IceboxDev wants to merge 1 commit intodbeaver:develfrom
IceboxDev wants to merge 1 commit intodbeaver:develfrom
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 4 |
| Duplication | 2 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LibSqlStatement.getUpdateCount()currently returnsrows_writtenunconditionally, including forSELECTqueries whererows_written == 0.Per the JDBC spec:
Returning
0instead of-1for a SELECT means "an update result with 0 rows affected" ? a different, legitimate state. Clients that walk all results via the standard pattern loop forever:This manifests in JetBrains DataGrip / PyCharm as the query showing rows in the editor but the "loading" spinner never stopping. Eventually the RMI proxy backing the Statement is GC'd on the driver side and the IDE log fills with
java.rmi.NoSuchObjectException: no such object in tablefromUniversalResultsProducer$StatementSource.hasMoreResultSets/getUpdateCount.Fix:
getUpdateCount/getLargeUpdateCountreturn-1when the current result is a ResultSet (signalled byexecutionResult.getColumns()being non-empty) or when there is no current result.getMoreResults()(both overloads) clearsexecutionResultandresultSetso subsequentgetUpdateCountcorrectly returns-1for "no more results".LibSqlException("No update count before statement execute")? per spec,getUpdateCountreturns-1in that state, it does not throw.