Fix Emscripten 6 compatibility: restore ERRNO_CODES and bind FS method context#114
Open
holub wants to merge 1 commit into
Open
Fix Emscripten 6 compatibility: restore ERRNO_CODES and bind FS method context#114holub wants to merge 1 commit into
holub wants to merge 1 commit into
Conversation
…d context Emscripten 6 made two breaking changes that break BrowserFS's EmscriptenFS shim: 1. ERRNO_CODES is no longer a global (removed in emscripten >=3.x). Pass FS, PATH, and an explicit errno map to EmscriptenFS so BrowserFS can map errno names to numbers. 2. FS node_ops/stream_ops methods are now called as bare functions (e.g. getattr(node) instead of node_ops.getattr(node)), losing . Bind all prototype methods on the node_ops and stream_ops wrapper instances so they retain their context. Without these fixes, accessing files under /emulator throws: TypeError: can't access property fs, this is undefined at $.getattr → fstat → ___syscall_fstat64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emscripten 6 made two breaking changes that break BrowserFS's EmscriptenFS shim:
Without these fixes, accessing files under /emulator throws:
TypeError: can't access property fs, this is undefined
at $.getattr → fstat → ___syscall_fstat64