Skip to content

Fix state transition lifecycle handling - #4

Open
davidask wants to merge 1 commit into
masterfrom
fix/state-transition-lifecycle
Open

Fix state transition lifecycle handling#4
davidask wants to merge 1 commit into
masterfrom
fix/state-transition-lifecycle

Conversation

@davidask

@davidask davidask commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • finish nonanimated transitions and report the correct previous state
  • balance child appearance callbacks across visibility changes and interrupted animations
  • prevent stale transition requests and animators from corrupting newer transitions
  • add iOS regression tests and run them in CI

Testing

  • xcodebuild -project StateViewController.xcodeproj -scheme StateViewController-Package -destination "platform=iOS Simulator,id=C817AC7A-61B1-4108-B583-64E45F8C3B90" test CODE_SIGNING_ALLOWED=NO IPHONEOS_DEPLOYMENT_TARGET=12.0
  • xcodebuild -project StateViewController.xcodeproj -scheme StateViewController-Package -sdk iphoneos -destination "generic/platform=iOS" build CODE_SIGNING_ALLOWED=NO IPHONEOS_DEPLOYMENT_TARGET=12.0
  • swiftlint lint --strict Sources/StateViewController/StateViewController.swift Tests/StateViewControllerTests/StateViewControllerTests.swift

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant