Track all status conditions per resource, not just one#571
Draft
Track all status conditions per resource, not just one#571
Conversation
Converts CustomResourceStateMetrics ConfigMap configs to ResourceMetricsPolicy CRD objects for the new resource-metrics operator. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Replace verbose per-condition CEL filter/exists logic with the new forEach field on metric specs. Each status-condition generator now iterates object.status.conditions once and emits one series per element via item.*, rather than hardcoding individual condition types. The quota-grant-creation-policy generator previously had two separate metrics (Ready + ParentContextReady); these are collapsed into a single forEach metric. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
scotwells
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Replaces the custom metrics sidecar with a
ResourceMetricsPolicythat instructs the resource-metrics operator to collect and export metrics for Milo's core resources (IAM, resource manager, quota).Each resource now emits:
ReadyPreviously the sidecar only tracked specific named conditions. With the new policy any condition the API server sets on a resource is automatically captured, so new condition types appear in dashboards and alerts without any config changes.
Test plan
Ready) show up as separate series per resource🤖 Generated with Claude Code