chore(ci): extract the eBPF toolchain install into a composite action - #363
Merged
Conversation
Five jobs (lint, test-unit, test-unit-root, build, test-e2e) each carried the same two-line apt install of the pinned clang-18/llvm-18/ linux-libc-dev toolchain, with the package pins explained in the build job and cross-referenced from the other four. The pins matter: they keep the BPF object bytes produced by one job identical to every other job's regeneration, and they have to move together with the workflow-level BPF2GO_CC pin. Five copies is five chances to bump one and miss the rest. The rationale now lives in the action, next to the packages it explains. Each job keeps only its own one-line note about why it needs the toolchain at all, which differs per job and is the part worth reading in place. Related to #314
privateip
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Five CI jobs each installed the same pinned eBPF toolchain, with the reasoning for the pins written out in one job and cross-referenced from the other four.
The pins are the point. They keep the compiled BPF object bytes identical across every job that regenerates them, and they have to move in step with the workflow-level compiler pin. Five copies means five chances to bump one and miss the rest.
Now there is one copy, in a composite action, with the reasoning next to the packages it explains. Each job keeps its own one-line note about why it needs the toolchain, since that part genuinely differs per job.
No behavior change. Same packages, same order, same jobs.
Test plan
task lint, including the yamlfmt pass over the new actiontask buildtask test:unittask test:e2eCI is the check here, since all five call sites are CI jobs.
Related to #314